Fix iOS artifacts issue in Microsoft.ML.OnnxRuntime Nuget Package #19311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YUNQIUGUO
commented
Jan 29, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
snnn
previously approved these changes
Jan 29, 2024
edgchen1
reviewed
Jan 29, 2024
edgchen1
reviewed
Jan 30, 2024
edgchen1
reviewed
Jan 30, 2024
Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
…/microsoft/onnxruntime into yguo/fix-nuget-ios-artifact-name
|
double-checked on the pipeline: https://aiinfra.visualstudio.com/Lotus/_build/results?buildId=404309&view=results . The Zip-Nuget-Java-NodeJs packaging pipeline now passes. Mind signing off this pr? thanks! |
snnn
approved these changes
Jan 30, 2024
YUNQIUGUO
added a commit
that referenced
this pull request
Jan 30, 2024
…9311) ### Description <!-- Describe your changes. --> Updates to only include ios archs framework in artifacts included in Nuget Package. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Related issue: #19295 (comment) --------- Co-authored-by: rachguo <rachguo@rachguos-Mini.attlocal.net> Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to only include ios archs framework in artifacts included in Nuget Package.
Motivation and Context
Related issue: #19295 (comment)