Add full iOS job in package pipeline #9036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
approved these changes
Sep 12, 2021
skottmckay
reviewed
Sep 13, 2021
| tools/ci_build/github/apple/default_full_ios_framework_build_settings.json | ||
| mkdir $(Build.BinariesDirectory)/artifacts | ||
| pushd $(Build.BinariesDirectory)/ios_framework/framework_out/ | ||
| zip -vr $(Build.BinariesDirectory)/artifacts/onnxruntime_xcframework.zip onnxruntime.xcframework |
There was a problem hiding this comment.
nit: is it possible to add a top level folder to the zip called something like onnxruntime-ios-xcframework? the extraction script that sets things up for insertion into the nuget package expects a directory containing the binaries with a trailing '-xyz' that it trims off.
There was a problem hiding this comment.
Can this be done in the download artifacts step? You can add whatever folder structure you want in the step.
Or is the folder structure need to be inside the zip?
There was a problem hiding this comment.
Will address this in a follow up PR
smk2007
pushed a commit
that referenced
this pull request
Sep 30, 2021
* Add full ios xcframework job * create zip file of the xcframework
smk2007
added a commit
that referenced
this pull request
Oct 1, 2021
* Add full iOS job in package pipeline (#9036) * Add full ios xcframework job * create zip file of the xcframework * Bump up TVM version to avoid conflict with existing one (#9159) * Bump up tvm version * Bump up onnxruntime-tvm version There are some c++17 related fixes in TVM Co-authored-by: KeDengMS <kedeng@microsoft.com> * fix bug introduced by PR9130 (#9166) * make uwp store apps link to statically-linked crt desktop builds (#9182) Co-authored-by: Sheil Kumar <sheilk@microsoft.com> * #9182 removed the `--is_store_build` option but one place where that was used was missed. (#9219) This should fix the relevant packaging pipelines. * DirectML.dll load fails when executable path contains Non-English characters (#9229) * enable unicode dml * add wide string L prefix * Add Fail Fast back Co-authored-by: Sheil Kumar <sheilk@microsoft.com> * Fix Android build break after Virtual Environment update to 20210919 (#9163) Co-authored-by: Guoyu Wang <62914304+gwang-msft@users.noreply.github.com> Co-authored-by: ke1337 <22626095+ke1337@users.noreply.github.com> Co-authored-by: KeDengMS <kedeng@microsoft.com> Co-authored-by: George Wu <jywu@microsoft.com> Co-authored-by: Sheil Kumar <sheilk@microsoft.com> Co-authored-by: Scott McKay <skottmckay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add full Android job in package pipeline
Motivation and Context
std::optionaldoes not havevalue()until iOS 12, change the usage fromstd::optional::value()to*std::optionalin relevant code