Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android build break after Virtual Environment update to 20210919 #9163

Merged
merged 9 commits into from Sep 23, 2021

Conversation

guoyu-wang
Copy link
Contributor

Description: Fix Android build break after Virtual Environment update to 20210919

Motivation and Context

snnn
snnn previously approved these changes Sep 23, 2021
edgchen1
edgchen1 previously approved these changes Sep 23, 2021
@snnn
Copy link
Member

snnn commented Sep 23, 2021

If needed, I can update Gradle to a newer version. But someone would help me fix the build errors.

@guoyu-wang guoyu-wang dismissed stale reviews from edgchen1 and snnn via dea37e8 September 23, 2021 02:53
@guoyu-wang
Copy link
Contributor Author

guoyu-wang commented Sep 23, 2021

If needed, I can update Gradle to a newer version. But someone would help me fix the build errors.

Update Gradle to 6.8.3 is probably safe, update Gradle to 7.0 may require some updates.

@guoyu-wang guoyu-wang merged commit ddafe50 into master Sep 23, 2021
@guoyu-wang guoyu-wang deleted the gwang-msft/fix_android_ndk branch September 23, 2021 17:07
mikeparker104 pushed a commit to mikeparker104/onnxruntime that referenced this pull request Sep 28, 2021
@guoyu-wang guoyu-wang mentioned this pull request Oct 1, 2021
smk2007 added a commit that referenced this pull request Oct 1, 2021
* Add full iOS job in package pipeline (#9036)

* Add full ios xcframework job

* create zip file of the xcframework

* Bump up TVM version to avoid conflict with existing one (#9159)

* Bump up tvm version

* Bump up onnxruntime-tvm version

There are some c++17 related fixes in TVM

Co-authored-by: KeDengMS <kedeng@microsoft.com>

* fix bug introduced by PR9130 (#9166)

* make uwp store apps link to statically-linked crt desktop builds (#9182)

Co-authored-by: Sheil Kumar <sheilk@microsoft.com>

* #9182 removed the `--is_store_build` option but one place where that was used was missed. (#9219)

This should fix the relevant packaging pipelines.

* DirectML.dll load fails when executable path contains Non-English characters (#9229)

* enable unicode dml

* add wide string L prefix

* Add Fail Fast back

Co-authored-by: Sheil Kumar <sheilk@microsoft.com>

* Fix Android build break after Virtual Environment update to 20210919  (#9163)

Co-authored-by: Guoyu Wang <62914304+gwang-msft@users.noreply.github.com>
Co-authored-by: ke1337 <22626095+ke1337@users.noreply.github.com>
Co-authored-by: KeDengMS <kedeng@microsoft.com>
Co-authored-by: George Wu <jywu@microsoft.com>
Co-authored-by: Sheil Kumar <sheilk@microsoft.com>
Co-authored-by: Scott McKay <skottmckay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants