New project structure and build scripts #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brunoborges Did you take a look at adoptium/containers? Might find some inspiration there (+ script to create official DockerHub config). |
karianna
reviewed
Sep 8, 2021
Anything in particular you believe could be leveraged? I looked into and did not find. Adoptium uses tar.gz while here we use Linux repositories. No need for checksum, for example. Multi-arch is interesting though, but I'm afraid we are not there yet. |
d3r3kk
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the Dockerfile structure on a per-base image, and then defines a list of available JDK versions in the
jdk_versionsfile, with abuild.shscript that is capable of building all images, or a single one.With this script, it is easier to define later on a PR for building/testing only specific base-images and/or JDK versions. Also enables better GitHub Actions workflow for.