Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New project structure and build scripts (#11) #19

Closed
wants to merge 3 commits into from

Conversation

brunoborges
Copy link
Member

Remake of #11

* new structure

* add --all to help message

* Adds better info message.

* Adds comment to use of ARG in Dockerfiles

* Adds a prefix to image tag name

* add 17

* Xshare dump for 11

* Create docker.yml

* add GH Action flow
Copy link
Member

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brunoborges brunoborges self-assigned this Oct 7, 2021
@brunoborges
Copy link
Member Author

This PR while OK, cannot be merged because the images are built in an internal Azure Pipelines infrastructure that needs to be updated, then tested with these changes.

@karianna
Copy link
Member

@brunoborges - will need a rebase

@karianna
Copy link
Member

@brunoborges - do you want to rebase or drop this PR?

@brunoborges brunoborges deleted the new-proj-layout branch March 16, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants