Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current waitFor* methods are easy to misuse as they require calling
.get()
on the returned object which is easy to forget if you just want to wait for certain condition and don't use the result. The API is updated in the following way:waitFor
) but become synchronous and have different return type.future
prefix. They are non-blocking and still returnDeferred<>
object:As before the client has to call
.get()
on the returned object in order to retrieve the result..get()
call is blocking. In the future we may add corresponding synchronouswaitFor*
methods for convenience if need be.Change in the behavior of
waitForFunction
is probably the most controversial as now there is no way to create the function before doing some actions with the page. Again if that turns out to be a problem in practice we'll addfutureCondition
or something that would restore existing behavior.