Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a pyee DeprecationWarning #1117

Closed
wants to merge 4 commits into from
Closed

Fixing a pyee DeprecationWarning #1117

wants to merge 4 commits into from

Conversation

jerichokeyne
Copy link

pyee.AsyncIOEventEmitter was moved to pyee.asyncio.AsyncIOEventEmitter, so this PR just fixes two imports

pyee.AsyncIOEventEmitter was moved to pyee.asyncio.AsyncIOEventEmitter
@ghost
Copy link

ghost commented Jan 20, 2022

CLA assistant check
All CLA requirements met.

@mxschmitt
Copy link
Member

I think we should also bump pyee to >=9.0.0 inside setup.py and meta.yaml otherwise it would break.

@jerichokeyne
Copy link
Author

Went ahead and updated those files

@mxschmitt
Copy link
Member

It seems like version 9.0 is not available on conda-forge yet: https://github.com/conda-forge/pyee-feedstock/ So we need to look into this one as well. I can try to dig into it tomorrow.

@mxschmitt
Copy link
Member

I opened conda-forge/pyee-feedstock#15 to fix the pyee conda-forge package. Since this is only about a deprecation warning, we can wait for that a few days.

@jerichokeyne
Copy link
Author

Thanks! And, definitely no urgency needed. Just wanted to try and get this warning fixed since it comes up every time I run my test scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants