Draft: Upgrade to pyee>=9.0.0 #1587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree [company="default"] |
|
@microsoft-github-policy-service agree |
jean-edouard-boulanger
changed the title
|
I see a couple of |
mxschmitt
reviewed
Oct 12, 2022
| @@ -24,7 +24,7 @@ requirements: | |||
| run: | |||
| - python | |||
| - greenlet ==1.1.3 | |||
| - pyee ==8.1.0 | |||
| - pyee >=9.0.0 | |||
There was a problem hiding this comment.
Suggested change
| - pyee >=9.0.0 | |
| - pyee ==9.0.4 |
let's keep that? In the past they broke us with a minor version bump.
mxschmitt
reviewed
Oct 12, 2022
| @@ -212,7 +212,7 @@ def _download_and_extract_local_driver( | |||
| include_package_data=True, | |||
| install_requires=[ | |||
| "greenlet==1.1.3", | |||
| "pyee==8.1.0", | |||
| "pyee>=9.0.0", | |||
This was referenced Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python playwright uses an old-ish version of
pyee(8.1.0) - this PR upgrades to >=9.0.0. There was a previous attempt here but was never merged because of pyee >=9.0.0 was not available in conda at that time. This is no longer the case:No regression between main and this branch.
Thanks for taking a look 🙏