add support for yarn pnp #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I closed the original issue because supporting non-Node runtimes is outside of the scope of Playwright at this point. |
|
Hi, I see that the microsoft/playwright#18931 issue has been closed but I'm curious why this and #229 PRs are still open. Is the team simply not interested in supporting yarn pnp or are there reservations to the particular PRs? I made a fork with support for myself, but I'm happy to contribute here if the team would prefer an alternate approach to solving the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to resolve the issue described here: microsoft/playwright#18931
I am aware of yet another PR that tries to solve the problem (#229), but I took a slightly different approach here.
All functions I've tested works, I have problem with some tests failing.