chore: pass playwright.env config to all node calls #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Uber" |
|
Hi, checking in again. Is this something the team is interested in reviewing? |
|
Hi, politely bumping again. I'm happy to make any changes if requested |
mxschmitt
reviewed
Apr 4, 2023
mxschmitt
reviewed
Apr 4, 2023
|
Thanks for your PR, after the requested changes we're happy to add it. Sorry for the slow response so far! |
|
Resolved the change requests. Thanks! |
mxschmitt
changed the title
pavelfeldman
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will support pnp package managers (yarn 2, pnpm) by allowing
NODE_OPTIONSto be configured withinplaywright.envand passed to node calls. For example, when using yarn 2 I can edit my.vscode/settings.jsonfile to below and register the pnp.cjs file.{ "playwright": { "env": { "NODE_OPTIONS": "-r ./.pnp.cjs" } } }