Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ambassadors #1323

Merged
merged 6 commits into from Mar 15, 2024
Merged

docs: update ambassadors #1323

merged 6 commits into from Mar 15, 2024

Conversation

debs-obrien
Copy link
Contributor

update ambassadors

@debs-obrien debs-obrien marked this pull request as draft March 13, 2024 20:03
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1323.centralus.azurestaticapps.net

1 similar comment
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1323.centralus.azurestaticapps.net

Copy link

@bwfellow bwfellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
name: 'Ben Fellows',
languages: 'English',
city: 'Traverse City',
country: 'USA',
githubUrl: 'https://github.com/bwfellow',
twitterUrl: 'https://twitter.com/FellowsBen'
},

@debs-obrien debs-obrien marked this pull request as ready for review March 14, 2024 07:53
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1323.centralus.azurestaticapps.net

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1323.centralus.azurestaticapps.net

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1323.centralus.azurestaticapps.net

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1323.centralus.azurestaticapps.net

@debs-obrien debs-obrien removed the request for review from bwfellow March 15, 2024 12:52
},
{
name: 'Are you the next Ambassador?',
city: '',
country: '',
imageUrl: 'https://playwright.dev/img/playwright-logo.svg'
imageUrl: 'playwright-logo.svg'
Copy link
Member

@mxschmitt mxschmitt Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
imageUrl: 'playwright-logo.svg'
imageUrl: '/img/playwright-logo.svg'

nit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't work as component uses the images from ambassadors folder so the svg is now also in that folder which also means it is independent from where else that image is. perhaps in future we might want to change the playwright ambassador image to a playwright tshirt or something

@debs-obrien debs-obrien merged commit f38d022 into main Mar 15, 2024
5 checks passed
@debs-obrien debs-obrien deleted the update-ambassadors branch March 15, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants