Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ambassadors #1323

Merged
merged 6 commits into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/ProfileCard/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type Person = {
twitterUrl?: string;
websiteUrl?: string;
linkedInUrl?: string;
imageUrl?: string;
imageUrl: string;
languages?: string;
};

Expand All @@ -44,7 +44,7 @@ function ProfileCard({ person, className }: ProfileProps) {
<img
className="avatar__photo avatar__photo--xl"
src={
person.githubUrl ? `${person.githubUrl}.png` : person.imageUrl
`../img/ambassadors/${person.imageUrl}`
}
alt={`${person.name}'s avatar`}
/>
Expand Down
49 changes: 28 additions & 21 deletions src/data/ambassadors.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,26 @@ const ambassadors = [
city: 'North Carolina',
country: 'USA',
githubUrl: 'https://github.com/AutomationPanda',
twitterUrl: 'https://twitter.com/AutomationPanda'
twitterUrl: 'https://twitter.com/AutomationPanda',
imageUrl: 'andy-knight.jpeg'
},
{
name: 'Ben Fellows',
languages: 'English',
city: 'Traverse City',
country: 'USA',
githubUrl: 'https://github.com/bwfellow',
twitterUrl: 'https://twitter.com/FellowsBen',
imageUrl: 'ben-fellows.png'
},
{
name: 'Butch Mayhew',
city: 'Birmingham',
languages: 'English',
country: 'USA',
imageUrl: 'https://pbs.twimg.com/profile_images/1287788058746720256/TI0zkGqB_400x400.jpg',
twitterUrl: 'https://twitter.com/butchmayhew',
websiteUrl: 'https://playwrightsolutions.com/'
websiteUrl: 'https://playwrightsolutions.com/',
imageUrl: 'butch-mayhew.jpg'
},
{
name: 'Carlos Gauto',
Expand All @@ -23,7 +33,8 @@ const ambassadors = [
country: 'Argentina',
githubUrl: 'https://github.com/charlyautomatiza',
twitterUrl: 'https://twitter.com/char_automatiza',
websiteUrl: 'https://linktr.ee/charlyautomatiza'
websiteUrl: 'https://linktr.ee/charlyautomatiza',
imageUrl: 'carlos-gauto.png'
},
{
name: 'Cory House',
Expand All @@ -32,33 +43,26 @@ const ambassadors = [
country: 'USA',
githubUrl: 'https://github.com/coryhouse',
twitterUrl: 'https://twitter.com/housecor',
websiteUrl: 'https://www.reactjsconsulting.com/'
websiteUrl: 'https://www.reactjsconsulting.com/',
imageUrl: 'cory-house.jpeg'
},
{
name: 'Jean-François Greffier',
city: 'Rennes',
languages: 'French, English',
country: 'France',
githubUrl: 'https://github.com/jfgreffier',
websiteUrl: 'https://linktr.ee/jfgreffier'
},
{
name: 'Giovanni Rago',
languages: 'Italian, English',
city: 'Berlin',
country: 'Germany',
imageUrl:
'https://pbs.twimg.com/profile_images/1419977078552813568/XVrltX2h_400x400.png',
twitterUrl: 'https://twitter.com/rag0g',
websiteUrl: 'https://www.youtube.com/c/AutomateTogether'
websiteUrl: 'https://linktr.ee/jfgreffier',
imageUrl: 'jean-francois.png'
},
{
name: 'John Hill',
languages: 'English',
city: 'Palo Alto',
country: 'USA',
githubUrl: 'https://github.com/unlikelyzero',
linkedInUrl: 'https://www.linkedin.com/in/linkedjohnhill'
linkedInUrl: 'https://www.linkedin.com/in/linkedjohnhill',
imageUrl: 'john-hill.jpeg'
},
{
name: 'Kent C. Dodds',
Expand All @@ -67,7 +71,8 @@ const ambassadors = [
country: 'USA',
githubUrl: 'https://github.com/kentcdodds',
twitterUrl: 'https://twitter.com/kentcdodds',
websiteUrl: 'https://kentcdodds.com'
websiteUrl: 'https://kentcdodds.com',
imageUrl: 'kent-c-dodds.jpeg'
},
{
name: 'Stefan Judis',
Expand All @@ -76,21 +81,23 @@ const ambassadors = [
country: 'Germany',
githubUrl: 'https://github.com/stefanjudis',
twitterUrl: 'https://twitter.com/stefanjudis',
websiteUrl: 'https://www.stefanjudis.com'
websiteUrl: 'https://www.stefanjudis.com',
imageUrl: 'stefan-judis.jpeg'
},
{
name: 'Tally Barak',
languages: 'Hebrew, English',
city: 'Tel Aviv',
country: 'Israel',
githubUrl: 'https://github.com/Tallyb',
twitterUrl: 'https://twitter.com/TallyBarak'
twitterUrl: 'https://twitter.com/TallyBarak',
imageUrl: 'tally-barak.jpeg'
},
{
name: 'Are you the next Ambassador?',
city: '',
country: '',
imageUrl: 'https://playwright.dev/img/playwright-logo.svg'
imageUrl: 'playwright-logo.svg'
Copy link
Member

@mxschmitt mxschmitt Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
imageUrl: 'playwright-logo.svg'
imageUrl: '/img/playwright-logo.svg'

nit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't work as component uses the images from ambassadors folder so the svg is now also in that folder which also means it is independent from where else that image is. perhaps in future we might want to change the playwright ambassador image to a playwright tshirt or something

}
];

Expand Down
6 changes: 4 additions & 2 deletions src/data/team.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ const team = [
languages: 'English, Spanish',
githubUrl: 'https://github.com/debs-obrien',
twitterUrl: 'https://twitter.com/debs_obrien',
linkedInUrl: 'https://www.linkedin.com/in/debbie-o-brien-1a199975/'
linkedInUrl: 'https://www.linkedin.com/in/debbie-o-brien-1a199975/',
imageUrl: 'debbie-obrien.jpeg'
},
{
name: 'Max Schmitt',
Expand All @@ -15,7 +16,8 @@ const team = [
country: 'Germany',
githubUrl: 'https://github.com/mxschmitt',
twitterUrl: 'https://twitter.com/mx_schmitt',
linkedInUrl: 'https://www.linkedin.com/in/max-schmitt/'
linkedInUrl: 'https://www.linkedin.com/in/max-schmitt/',
imageUrl: 'max-schmitt.jpeg'
}
];

Expand Down
Binary file added static/img/ambassadors/andy-knight.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/ambassadors/ben-fellows.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/ambassadors/butch-mayhew.jpg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/ambassadors/carlos-gauto.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/ambassadors/cory-house.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/ambassadors/debbie-obrien.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/ambassadors/jean-francois.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/ambassadors/john-hill.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/ambassadors/kent-c-dodds.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/ambassadors/max-schmitt.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions static/img/ambassadors/playwright-logo.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/ambassadors/stefan-judis.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/ambassadors/tally-barak.jpeg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.