fix(permissions): fix notifications permissions on firefox (#1531)

microsoft · Mar 25, 2020 · ef9e04d · ef9e04d
1 parent 6be3634
commit ef9e04d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -9,7 +9,7 @@
   "main": "index.js",
   "playwright": {
     "chromium_revision": "751710",
-    "firefox_revision": "1054",
+    "firefox_revision": "1056",
     "webkit_revision": "1182"
   },
   "scripts": {

diff --git a/test/permissions.spec.js b/test/permissions.spec.js
@@ -52,19 +52,19 @@ module.exports.describe = function({testRunner, expect, WEBKIT, FFOX}) {
       await context.grantPermissions(['geolocation'], { origin: server.EMPTY_PAGE });
       expect(await getPermission(page, 'geolocation')).toBe('granted');
     });
-    it.fail(FFOX)('should grant notifications permission when listed', async({page, server, context}) => {
+    it('should grant notifications permission when listed', async({page, server, context}) => {
       await page.goto(server.EMPTY_PAGE);
       await context.grantPermissions(['notifications'], { origin: server.EMPTY_PAGE });
       expect(await getPermission(page, 'notifications')).toBe('granted');
     });
-    it.fail(FFOX)('should accumulate when adding', async({page, server, context}) => {
+    it('should accumulate when adding', async({page, server, context}) => {
       await page.goto(server.EMPTY_PAGE);
       await context.grantPermissions(['geolocation']);
       await context.grantPermissions(['notifications']);
       expect(await getPermission(page, 'geolocation')).toBe('granted');
       expect(await getPermission(page, 'notifications')).toBe('granted');
     });
-    it.fail(FFOX)('should clear permissions', async({page, server, context}) => {
+    it('should clear permissions', async({page, server, context}) => {
       await page.goto(server.EMPTY_PAGE);
       await context.grantPermissions(['geolocation']);
       await context.clearPermissions();