fix(permissions): fix notifications permissions on firefox #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Mar 25, 2020
test/permissions.spec.js
Outdated
| await page.goto(server.EMPTY_PAGE); | ||
| await context.grantPermissions(['notifications'], { origin: server.EMPTY_PAGE }); | ||
| await page.waitFor(3000); |
pavelfeldman
commented
Mar 25, 2020
There was a problem hiding this comment.
I think browser patch has a bug, so I wonder whether the flakiness is still there?
My patch is not fixing flakiness, it makes notifications permissions work. If you follow the code, you can see that exception on the content side was the thing that 'fixed' the flakiness in the first place. The bug you saw in the browser side was me making last-minute call beautification.
Since then I reworked the browser-side patch to only do the empty rountrip, it turned out that the perm-change event that it awaited never arrived.
dgozman
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.