Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Keep VSCode project order from config #30936

Closed
mxschmitt opened this issue May 21, 2024 · 0 comments · Fixed by microsoft/playwright-vscode#489
Closed

[Feature]: Keep VSCode project order from config #30936

mxschmitt opened this issue May 21, 2024 · 0 comments · Fixed by microsoft/playwright-vscode#489

Comments

@mxschmitt
Copy link
Member

mxschmitt commented May 21, 2024

const projectClosure = buildProjectsClosure([...filesToRunByProject.keys()]);
for (const [project, type] of projectClosure) {
if (type === 'dependency') {
filesToRunByProject.delete(project);
const treatProjectAsEmpty = doNotRunTestsOutsideProjectFilter && !filteredProjects.includes(project);
const files = treatProjectAsEmpty ? [] : allFilesForProject.get(project) || await collectFilesForProject(project, fsCache);
filesToRunByProject.set(project, files);
}
}

is messing up the order as of today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant