Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Firefox: strange undefined toJSON property on JS objects #7015

Closed
creage opened this issue Jun 10, 2021 · 3 comments
Closed

[BUG] Firefox: strange undefined toJSON property on JS objects #7015

creage opened this issue Jun 10, 2021 · 3 comments
Assignees
@aslushnikov
Labels
browser-firefox P1-resolve-asap

Comments

@creage
Copy link

creage commented Jun 10, 2021

Context:

  • Playwright Version: 1.12.1
  • Operating System: Windows
  • Node.js version: 14.6.1
  • Browser: Firefox

Describe the bug
After evaluating some custom code in the context of the page, some of JS objects receive strange toJSON property, which is undefined. Started to happen after upgrade to 1.12. And this happens on Firefox ONLY.
@mxschmitt
Copy link
Member

mxschmitt commented Jun 10, 2021 •
edited
Loading

Caused by #6767

@mxschmitt mxschmitt mentioned this issue Jun 10, 2021
Merged
@mxschmitt mxschmitt self-assigned this Jun 10, 2021
@mxschmitt mxschmitt added v1.12 and removed v1.12.1 labels Jun 10, 2021
@mxschmitt mxschmitt mentioned this issue Jun 10, 2021
Merged
@mxschmitt mxschmitt assigned aslushnikov and unassigned mxschmitt Jun 10, 2021
@creage
Copy link
Author

creage commented Jun 10, 2021

Oh gosh, this reminds me old issues you guys might not even heard about 😄

That library taught all of us one thing - you should never modify objects you don't own.

@mxschmitt
Copy link
Member

mxschmitt commented Jun 10, 2021 •
edited
Loading

This was the original reason why we implemented this fix (prototype.js) to bypass a broken Array.prototype.toJSON method. This lead to a broken Array.prototype.toJSON method for all users. Should get fixed soon.

aslushnikov added a commit to aslushnikov/playwright that referenced this issue Jun 10, 2021
@aslushnikov
browser(firefox): move to the hand-written JSON serializer
e79cc6a 
The hand-written JSON serializer works in user context and doesn't
invoke `toJSON` methods.

References microsoft#7015
@aslushnikov aslushnikov mentioned this issue Jun 10, 2021
Closed
aslushnikov pushed a commit that referenced this issue Jun 11, 2021
@mxschmitt
browser(firefox): fixed Array.prototype.toJSON workaround (#7018)
9b9091b 
References #7015
@aslushnikov aslushnikov added this to the v1.12.2 milestone Jun 11, 2021
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Jun 11, 2021
@aslushnikov
feat: roll Firefox to r1271
937c4e0 
References microsoft#7015
@aslushnikov aslushnikov mentioned this issue Jun 11, 2021
Merged
aslushnikov added a commit that referenced this issue Jun 11, 2021
@aslushnikov
feat: roll Firefox to r1271 (#7067)
d6831df 
References #7015
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Jun 11, 2021
@aslushnikov
cherry-pick(release-1.12): roll Firefox to r1271
aa14ac0 
Cherry-Pick microsoft#7067 SHA d6831df

NOTE: this cherry-pick updates only firefox-stable build revision
and keeps the firefox-beta as-is since it's been rolled already.
Thus, the new test is explicitly skipped on firefox-beta.

Fixes microsoft#7015
@aslushnikov aslushnikov mentioned this issue Jun 11, 2021
Merged
aslushnikov added a commit that referenced this issue Jun 11, 2021
@aslushnikov
cherry-pick(release-1.12): roll Firefox to r1271 (#7075)
6ad4e7a 
Cherry-Pick #7067 SHA d6831df

NOTE: this cherry-pick updates only firefox-stable build revision
and keeps the firefox-beta as-is since it's been rolled already.
Thus, the new test is explicitly skipped on firefox-beta.

Fixes #7015
@renovate renovate bot mentioned this issue Jun 14, 2021
Merged
1 task
@csxero csxero mentioned this issue Jun 14, 2021
Closed
@Paramesh82 Paramesh82 mentioned this issue Jun 14, 2021
Closed
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Jun 17, 2021
@aslushnikov
browser(firefox): move to the hand-written JSON serializer
a05401b 
The hand-written JSON serializer works in user context and doesn't
invoke `toJSON` methods.

References microsoft#7015
@YusukeIwaki YusukeIwaki mentioned this issue Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslushnikov aslushnikov

Labels
browser-firefox P1-resolve-asap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aslushnikov @creage @mxschmitt