feat(matchers): add expect(locator).toContainClass() #14219
Conversation
|
|
Diokuz
force-pushed
the
main
branch
4 times, most recently
from
44cd222
to
04e2b47
Compare
Diokuz
force-pushed
the
main
branch
2 times, most recently
from
a731e09
to
be98ef4
Compare
Co-authored-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Max Schmitt <max@schmitt.mx>
|
@mxschmitt looks like I fixed everything you comment. What next? |
| await expect(itemLocator).toContainClass(['alice', 'bob', 'carl']); // fail, length mismatch | ||
| ``` | ||
|
|
||
| ```java |
There was a problem hiding this comment.
All languages should have equivalent examples. You can make JS snippet smaller or other languages bigger.
There was a problem hiding this comment.
I just copypasted docs for toHaveClass and renamed it :)
| @@ -1297,9 +1297,9 @@ export class Frame extends SdkObject { | |||
| omitAttached = true; | |||
| else if (options.isNot && options.expression === 'to.have.count' && options.expectedNumber !== 0) | |||
| omitAttached = true; | |||
| else if (!options.isNot && options.expression.endsWith('.array') && options.expectedText!.length === 0) | |||
| else if (!options.isNot && options.expression.endsWith('.array') && options.expectedText?.length === 0) | |||
There was a problem hiding this comment.
Because expectedText could be undefined, and it is in my case.
| omitAttached = true; | ||
| else if (options.isNot && options.expression.endsWith('.array') && options.expectedText!.length > 0) | ||
| else if (options.isNot && options.expression.endsWith('.array') && (options.expectedText?.length || 0) > 0) |
| if (expression === 'to.contain.class.array') { | ||
| const receivedClassNames = elements.map(e => e.className); | ||
|
|
||
| if (!Array.isArray(options.expectedValue) || options.expectedValue.length !== elements.length) |
There was a problem hiding this comment.
This does not match the logic of to.contain.text.array, toContainClass relative to toHaveClass should be the same as toContainText relative to toHaveText, let's make sure they are consistent.
There was a problem hiding this comment.
Could you please give me a testcase for what you are saying? This condition just ensures that elements and values length are equal.
Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
|
So, guys, I think this mr on your side now) I'll continue to watch for #14117 |
#14117