docs(dotnet): consistent access modifiers #16331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdeschryver
commented
Aug 6, 2022
| @@ -299,7 +299,7 @@ dotnet test | |||
| You can also choose specifically which tests to run, using the [filtering capabilities](https://docs.microsoft.com/en-us/dotnet/core/testing/selective-unit-tests?pivots=mstest): | |||
|
|
|||
| ```bash | |||
| dotnet test --filter "Name~ShouldAdd" | |||
| dotnet test --filter "Name~Slogan" | |||
There was a problem hiding this comment.
Running this command against the examples result that no tests are executed.
I thought it would be better to filter a test from the examples while still having one test executed, if this is unwanted I can revert this change.
mxschmitt
approved these changes
Aug 7, 2022
|
Thank you Tim, appreciate your contribution to the project! |
mxschmitt
pushed a commit
to mxschmitt/playwright
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
public asyncinstead ofasync publicto use the same access modifiers in all examples.My IDE (Rider) was also giving a warning on using
async public.While I was in the files making the changes, I also caught a few typos.