docs: Browsers page rework #21051
Merged
docs: Browsers page rework #21051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Feb 22, 2023
Co-authored-by: Dmitry Gozman <dgozman@gmail.com> Signed-off-by: Debbie O'Brien <debs-obrien@users.noreply.github.com>
dgozman
reviewed
Feb 23, 2023
Co-authored-by: Dmitry Gozman <dgozman@gmail.com> Signed-off-by: Debbie O'Brien <debs-obrien@users.noreply.github.com>
mxschmitt
reviewed
Feb 23, 2023
dgozman
approved these changes
Feb 27, 2023
docs/src/browsers.md
Outdated
| /* Test against branded browsers. */ | ||
| { | ||
| name: 'Microsoft Edge', | ||
| use: { channel: 'msedge' }, // or 'msedge-beta', 'msedge-dev' |
There was a problem hiding this comment.
Suggested change
| use: { channel: 'msedge' }, // or 'msedge-beta', 'msedge-dev' | |
| use: { ...devices['Desktop Edge'], channel: 'msedge' }, // or 'msedge-beta', 'msedge-dev' |
docs/src/browsers.md
Outdated
| ``` | ||
|
|
||
| ```powershell tab=bash-powershell lang=python | ||
| ```python async | ||
| # Can be "msedge", "chrome-beta", "msedge-beta", "msedge-dev", etc. |
There was a problem hiding this comment.
Use --browser-channel from https://playwright.dev/python/docs/test-runners#cli-arguments.
mxschmitt
reviewed
Feb 28, 2023
docs/src/browsers.md
Outdated
| ## Run tests on different browsers | ||
| Test against mobile viewports: | ||
|
|
||
| ```python |
mxschmitt
reviewed
Feb 28, 2023
docs/src/browsers.md
Outdated
| ``` | ||
| Test against branded browsers: | ||
|
|
||
| ```python |
mxschmitt
reviewed
Feb 28, 2023
mxschmitt
reviewed
Feb 28, 2023
|
|
||
| In certain cases, it is desired to avoid browser downloads altogether because | ||
| browser binaries are managed separately. | ||
|
|
||
| This can be done by setting `PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD` variable before installation. | ||
|
|
||
| ```bash tab=bash-bash lang=js |
There was a problem hiding this comment.
lets remove these 3 snippets as per https://github.com/microsoft/playwright/pull/21051/files#r1115394962?
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.