docs(browsers): code snippet follow-ups #21383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Mar 3, 2023
| @@ -133,10 +133,11 @@ pwsh bin/Debug/netX/playwright.ps1 install --with-deps chromium | |||
| ``` | |||
|
|
|||
| ## Update Playwright regulary | |||
| * langs: js | |||
There was a problem hiding this comment.
Why js only? It's a good cross-language advice.
There was a problem hiding this comment.
Updating the dependency is hard in Java, maven/gradle, Python, conda,pip,potry, dotnet nuget so I'd keep it Node.js only for now.
docs/src/browsers.md
Outdated
| playwright.webkit(), | ||
| playwright.firefox() | ||
| ); | ||
| for (BrowserType browserType : browserTypes) { |
There was a problem hiding this comment.
To be fair, this is probably not how you do it. Let's ask Yury, but I'd think using env.BROWSER is a better way.
mxschmitt
force-pushed
the
docs-browsers-follow-ups
branch
from
3e4a12b
to
3dffa2c
Compare
pavelfeldman
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #21051.