Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devops: do not use NPX during docker container build #23213

Merged
merged 1 commit into from
May 23, 2023
Merged

devops: do not use NPX during docker container build #23213

merged 1 commit into from
May 23, 2023

Commits on May 22, 2023

  1. devops: do not use NPX during docker container build 

    The postmortem of the broken docker image:
- We use `playwright-core` package when bootstrapping our docker
container.
- Due to accidental removal of `bin` entry in the `playwright-core` (see
  microsoft#23206), the `npx
  playwright install --with-deps` was using the last published
  Playwright version instead of a locally-built playwright binary

This patch starts using `npx exec --no` to make sure that we never call
remote commands during docker image build.
    @aslushnikov
    aslushnikov committed May 22, 2023
    Configuration menu
    Copy the full SHA
    1c44844 View commit details
    Browse the repository at this point in the history