fix(webkit): balance ref/unref calls for the default data manager #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yury-s/WebKit@c3a95c2
This changes fixes following crash:
Thread 1 (Thread 0x7efd425bbe40 (LWP 11642)):
, argc=2, argv=0x7ffcac3e1098, init=, fini=, rtld_fini=, stack_end=0x7ffcac3e1088) at ../csu/libc-start.c:344#0 WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:305
No locals.
#1 0x00007efd5d6f2f3b in WTFCrashWithInfo () at DerivedSources/ForwardingHeaders/wtf/Assertions.h:622
No locals.
#2 0x00007efd5e368512 in _WebKitWebsiteDataManagerPrivate::~_WebKitWebsiteDataManagerPrivate (this=0x1fc6500) at ../../Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp:95
No locals.
#3 0x00007efd5e365d01 in webkit_website_data_manager_finalize (object=0x1fc6560) at ../../Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp:112
self = 0x1fc6560
#4 0x00007efd67627e62 in g_object_unref () at ../../Source/glib-2.58.1/gobject/gobject.c:3346
No locals.
#5 0x00007efd5e3300e3 in WTF::derefGPtr<_WebKitWebsiteDataManager> (ptr=0x1fc6560) at DerivedSources/ForwardingHeaders/wtf/glib/GRefPtr.h:255
No locals.
#6 0x00007efd5e330076 in WTF::GRefPtr<_WebKitWebsiteDataManager>::operator= (this=0x230e058, optr=0x0) at DerivedSources/ForwardingHeaders/wtf/glib/GRefPtr.h:157
ptr = 0x1fc6560
#7 0x00007efd5e32db26 in webkitWebContextDispose (object=0x230e150) at ../../Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:436
priv = 0x230e000
#8 0x00007efd67627df3 in g_object_unref () at ../../Source/glib-2.58.1/gobject/gobject.c:3309
No locals.
#9 0x00007efd5e333373 in WTF::derefGPtr<_WebKitWebContext> (ptr=0x230e150) at DerivedSources/ForwardingHeaders/wtf/glib/GRefPtr.h:255
No locals.
#10 0x00007efd5e3332fb in WTF::GRefPtr<_WebKitWebContext>::~GRefPtr (this=0x7efd675c1660 <createDefaultWebContext(void*)::webContext>) at DerivedSources/ForwardingHeaders/wtf/glib/GRefPtr.h:77
ptr = 0x230e150
#11 0x00007efd47b61041 in __run_exit_handlers (status=0, listp=0x7efd47f09718 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108
atfct =
onfct =
cxafct =
f =
new_exitfn_called = 1559
cur = 0x1f04df0
#12 0x00007efd47b6113a in __GI_exit (status=) at exit.c:139
No locals.
#13 0x00007efd47b3fb9e in __libc_start_main (main=0x41af60
result =
unwind_buf = {cancel_jmp_buf = {{jmp_buf = {0, 3275525820627785672, 4246480, 140723198234768, 0, 0, -3275144291071846456, -3418356888933394488}, mask_was_saved = 0}}, priv = {pad = {0x0, 0x0, 0x7efd675f3733 <_dl_init+259>, 0x7efd66d6f7f8}, data = {prev = 0x0, cleanup = 0x0, canceltype = 1734293299}}}
not_first_call =
#14 0x000000000040cbfa in _start ()
No symbol table info available.