fix(doc): npm run doc fixed #2

pavelfeldman · 2019-11-19T05:33:13Z

No description provided.

JoelEinbinder · 2019-11-19T05:35:39Z

utils/doclint/cli.js

    const api = await Source.readFile(path.join(PROJECT_DIR, 'docs', 'api.md'));
-    const troubleshooting = await Source.readFile(path.join(PROJECT_DIR, 'docs', 'troubleshooting.md'));


what happened to these files?

I removed them since they were Chromium & Pptr centric

Did we lose anything else in the move?

This patch detects Chromium crash with a sandboxing error and re-writes the error to surface information nicely. ```sh pwuser@396166c88ec2:/root/playwright$ node a.js (node:9916) UnhandledPromiseRejectionWarning: browserType.launch: Protocol error (Target.setAutoAttach): Target closed. =========================== logs =========================== [browser] <launching> /home/pwuser/.cache/ms-playwright/chromium-786218/chrome-linux/chrome --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disab le-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=TranslateUI,BlinkGenPropertyTrees,ImprovedCookieControls,SameSiteByDefaultCookies --disable-hang-monitor --disab le-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --user-data-dir=/tmp/playwrig ht_chromiumdev_profile-S7DvGF --remote-debugging-pipe --headless --hide-scrollbars --mute-audio --no-startup-window [browser] <launched> pid=9993 [browser] [0721/210028.684682:FATAL:zygote_host_impl_linux.cc(117)] No usable sandbox! Update your kernel or see https://chromium.googlesource.com/chromium/src/+/master/docs/linux/suid_sandbox_development.md for more information on developing with the SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox. [browser] #0 0x55604e10fca9 base::debug::CollectStackTrace() [browser] #1 0x55604e08abb3 base::debug::StackTrace::StackTrace() [browser] microsoft#2 0x55604e09c810 logging::LogMessage::~LogMessage() [browser] microsoft#3 0x55604c7e68de content::ZygoteHostImpl::Init() [browser] microsoft#4 0x55604dc56067 content::ContentMainRunnerImpl::Initialize() [browser] microsoft#5 0x55604dca493a service_manager::Main() [browser] microsoft#6 0x55604dc54681 content::ContentMain() [browser] microsoft#7 0x55604dca365d headless::(anonymous namespace)::RunContentMain() [browser] microsoft#8 0x55604dca335c headless::HeadlessShellMain() [browser] microsoft#9 0x55604b5a0527 ChromeMain [browser] microsoft#10 0x7fcbfda52b97 __libc_start_main [browser] microsoft#11 0x55604b5a036a _start [browser] [browser] Received signal 6 [browser] #0 0x55604e10fca9 base::debug::CollectStackTrace() [browser] #1 0x55604e08abb3 base::debug::StackTrace::StackTrace() [browser] microsoft#2 0x55604e10f845 base::debug::(anonymous namespace)::StackDumpSignalHandler() [browser] microsoft#3 0x7fcc03ee3890 (/lib/x86_64-linux-gnu/libpthread-2.27.so+0x1288f) [browser] microsoft#4 0x7fcbfda6fe97 gsignal [browser] microsoft#5 0x7fcbfda71801 abort [browser] microsoft#6 0x55604e10e7a5 base::debug::BreakDebugger() [browser] microsoft#7 0x55604e09cc7b logging::LogMessage::~LogMessage() [browser] microsoft#8 0x55604c7e68de content::ZygoteHostImpl::Init() [browser] microsoft#9 0x55604dc56067 content::ContentMainRunnerImpl::Initialize() [browser] microsoft#10 0x55604dca493a service_manager::Main() [browser] microsoft#11 0x55604dc54681 content::ContentMain() [browser] microsoft#12 0x55604dca365d headless::(anonymous namespace)::RunContentMain() [browser] microsoft#13 0x55604dca335c headless::HeadlessShellMain() [browser] microsoft#14 0x55604b5a0527 ChromeMain [browser] microsoft#15 0x7fcbfda52b97 __libc_start_main [browser] microsoft#16 0x55604b5a036a _start [browser] r8: 0000000000000000 r9: 00007fff94da5d90 r10: 0000000000000008 r11: 0000000000000246 [browser] r12: 00007fff94da7060 r13: 00007fff94da5ff0 r14: 00007fff94da7070 r15: aaaaaaaaaaaaaaaa [browser] di: 0000000000000002 si: 00007fff94da5d90 bp: 00007fff94da5fe0 bx: 00007fff94da6824 [browser] dx: 0000000000000000 ax: 0000000000000000 cx: 00007fcbfda6fe97 sp: 00007fff94da5d90 [browser] ip: 00007fcbfda6fe97 efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000 [browser] trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [browser] [end of stack trace] [browser] Calling _exit(1). Core file will not be generated. ============================================================ Note: use DEBUG=pw:api environment variable and rerun to capture Playwright logs.Error at /root/playwright/lib/chromium/crConnection.js:131:63 at new Promise (<anonymous>) at CRSession.send (/root/playwright/lib/chromium/crConnection.js:130:16) at CRSession.send (/root/playwright/lib/helper.js:78:31) at Function.connect (/root/playwright/lib/chromium/crBrowser.js:54:27) at Chromium._connectToTransport (/root/playwright/lib/server/chromium.js:53:38) at Chromium._innerLaunch (/root/playwright/lib/server/browserType.js:87:36) at async ProgressController.run (/root/playwright/lib/progress.js:75:28) at async Chromium.launch (/root/playwright/lib/server/browserType.js:60:25) at async /root/playwright/a.js:4:19 (node:9916) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejec tion, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2) (node:9916) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. ``` ```sh pwuser@396166c88ec2:/root/playwright$ node a.js (node:10074) UnhandledPromiseRejectionWarning: Chromium sandboxing failed! ================================ To workaround sandboxing issues, do either of the following: - (preferred): Configure environment to support sandboxing: https://github.com/microsoft/playwright/blob/master/docs/troubleshooting.md - (alternative): Launch Chromium without sandbox using 'chromiumSandbox: false' option ================================ Error at /root/playwright/lib/chromium/crConnection.js:131:63 at new Promise (<anonymous>) at CRSession.send (/root/playwright/lib/chromium/crConnection.js:130:16) at CRSession.send (/root/playwright/lib/helper.js:78:31) at Function.connect (/root/playwright/lib/chromium/crBrowser.js:54:27) at Chromium._connectToTransport (/root/playwright/lib/server/chromium.js:53:38) at Chromium._innerLaunch (/root/playwright/lib/server/browserType.js:87:36) at async ProgressController.run (/root/playwright/lib/progress.js:75:28) at async Chromium.launch (/root/playwright/lib/server/browserType.js:60:25) at async /root/playwright/a.js:4:19 (node:10074) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2) (node:10074) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. ```

This patch detects Chromium crash with a sandboxing error and re-writes the error to surface information nicely. #### Error Before: ```sh pwuser@23592d09b3bd:~/tmp$ node a.js (node:324) UnhandledPromiseRejectionWarning: browserType.launch: Protocol error (Browser.getVersion): Target closed. =========================== logs =========================== [browser] <launching> /home/pwuser/.cache/ms-playwright/chromium-790602/chrome-linux/chrome --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disab le-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=TranslateUI,BlinkGenPropertyTrees,ImprovedCookieControls,SameSiteByDefaultCookies --disable-hang-monitor --disab le-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --user-data-dir=/tmp/playwrig ht_chromiumdev_profile-mjSfr2 --remote-debugging-pipe --headless --hide-scrollbars --mute-audio --no-startup-window [browser] <launched> pid=401 [browser] [0722/170825.030020:FATAL:zygote_host_impl_linux.cc(117)] No usable sandbox! Update your kernel or see https://chromium.googlesource.com/chromium/src/+/master/docs/linux/suid_sandbox_development.md for more information on developing with the SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox. [browser] #0 0x55ac4f8c7be9 base::debug::CollectStackTrace() [browser] #1 0x55ac4f841c13 base::debug::StackTrace::StackTrace() [browser] #2 0x55ac4f853680 logging::LogMessage::~LogMessage() [browser] #3 0x55ac4df2307e content::ZygoteHostImpl::Init() [browser] #4 0x55ac4f40dd47 content::ContentMainRunnerImpl::Initialize() [browser] #5 0x55ac4f45c9fa service_manager::Main() [browser] #6 0x55ac4f40c361 content::ContentMain() [browser] #7 0x55ac4f45b5bd headless::(anonymous namespace)::RunContentMain() [browser] #8 0x55ac4f45b2bc headless::HeadlessShellMain() [browser] #9 0x55ac4ccc22e7 ChromeMain [browser] #10 0x7f0f3d736b97 __libc_start_main [browser] #11 0x55ac4ccc212a _start [browser] [browser] Received signal 6 [browser] #0 0x55ac4f8c7be9 base::debug::CollectStackTrace() [browser] #1 0x55ac4f841c13 base::debug::StackTrace::StackTrace() [browser] #2 0x55ac4f8c7785 base::debug::(anonymous namespace)::StackDumpSignalHandler() [browser] #3 0x7f0f437b3890 (/lib/x86_64-linux-gnu/libpthread-2.27.so+0x1288f) [browser] #4 0x7f0f3d753e97 gsignal [browser] #5 0x7f0f3d755801 abort [browser] #6 0x55ac4f8c66e5 base::debug::BreakDebugger() [browser] #7 0x55ac4f853aeb logging::LogMessage::~LogMessage() [browser] #8 0x55ac4df2307e content::ZygoteHostImpl::Init() [browser] #9 0x55ac4f40dd47 content::ContentMainRunnerImpl::Initialize() [browser] #10 0x55ac4f45c9fa service_manager::Main() [browser] #11 0x55ac4f40c361 content::ContentMain() [browser] #12 0x55ac4f45b5bd headless::(anonymous namespace)::RunContentMain() [browser] #13 0x55ac4f45b2bc headless::HeadlessShellMain() [browser] #14 0x55ac4ccc22e7 ChromeMain [browser] #15 0x7f0f3d736b97 __libc_start_main [browser] #16 0x55ac4ccc212a _start [browser] r8: 0000000000000000 r9: 00007ffd38a863b0 r10: 0000000000000008 r11: 0000000000000246 [browser] r12: 00007ffd38a87680 r13: 00007ffd38a86610 r14: 00007ffd38a87690 r15: aaaaaaaaaaaaaaaa [browser] di: 0000000000000002 si: 00007ffd38a863b0 bp: 00007ffd38a86600 bx: 00007ffd38a86e44 [browser] dx: 0000000000000000 ax: 0000000000000000 cx: 00007f0f3d753e97 sp: 00007ffd38a863b0 [browser] ip: 00007f0f3d753e97 efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000 [browser] trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [browser] [end of stack trace] [browser] Calling _exit(1). Core file will not be generated. ============================================================ Note: use DEBUG=pw:api environment variable and rerun to capture Playwright logs.Error at /home/pwuser/tmp/node_modules/playwright/lib/chromium/crConnection.js:131:63 at new Promise (<anonymous>) at CRSession.send (/home/pwuser/tmp/node_modules/playwright/lib/chromium/crConnection.js:130:16) at CRSession.send (/home/pwuser/tmp/node_modules/playwright/lib/helper.js:78:31) at Function.connect (/home/pwuser/tmp/node_modules/playwright/lib/chromium/crBrowser.js:54:39) at Chromium._connectToTransport (/home/pwuser/tmp/node_modules/playwright/lib/server/chromium.js:52:38) at Chromium._innerLaunch (/home/pwuser/tmp/node_modules/playwright/lib/server/browserType.js:87:36) at async ProgressController.run (/home/pwuser/tmp/node_modules/playwright/lib/progress.js:75:28) at async Chromium.launch (/home/pwuser/tmp/node_modules/playwright/lib/server/browserType.js:60:25) at async /home/pwuser/tmp/a.js:4:19 (node:324) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise reject ion, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2) (node:324) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. ``` #### Error After: ```sh pwuser@23592d09b3bd:~/tmp$ node a.js (node:222) UnhandledPromiseRejectionWarning: browserType.launch: Chromium sandboxing failed! ================================ To workaround sandboxing issues, do either of the following: - (preferred): Configure environment to support sandboxing: https://github.com/microsoft/playwright/blob/master/docs/troubleshooting.md - (alternative): Launch Chromium without sandbox using 'chromiumSandbox: false' option ================================ Error at /home/pwuser/tmp/node_modules/playwright/lib/chromium/crConnection.js:131:63 at new Promise (<anonymous>) at CRSession.send (/home/pwuser/tmp/node_modules/playwright/lib/chromium/crConnection.js:130:16) at CRSession.send (/home/pwuser/tmp/node_modules/playwright/lib/helper.js:78:31) at Function.connect (/home/pwuser/tmp/node_modules/playwright/lib/chromium/crBrowser.js:54:27) at Chromium._connectToTransport (/home/pwuser/tmp/node_modules/playwright/lib/server/chromium.js:53:38) at Chromium._innerLaunch (/home/pwuser/tmp/node_modules/playwright/lib/server/browserType.js:89:36) at async ProgressController.run (/home/pwuser/tmp/node_modules/playwright/lib/progress.js:75:28) at async Chromium.launch (/home/pwuser/tmp/node_modules/playwright/lib/server/browserType.js:61:25) at async /home/pwuser/tmp/a.js:4:19 (node:222) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise reject ion, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2) (node:222) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. ``` References #2745

chore(ct): resolve pr comments

pavelfeldman requested a review from JoelEinbinder November 19, 2019 05:34

JoelEinbinder reviewed Nov 19, 2019

View reviewed changes

aslushnikov force-pushed the master branch from 8ab0a11 to 9ba375c Compare November 19, 2019 18:58

JoelEinbinder approved these changes Nov 19, 2019

View reviewed changes

doc: fix doc linter

a588167

pavelfeldman merged commit 60f332d into microsoft:master Nov 19, 2019

pavelfeldman deleted the docs branch November 19, 2019 21:59

yury-s mentioned this pull request Dec 16, 2019

fix(webkit): balance ref/unref calls for the default data manager #256

Merged

diervo mentioned this pull request Jan 24, 2020

Running Playwright in Heroku #634

Closed

pavelfeldman mentioned this pull request Jan 31, 2020

docs(selectors): update zs section #779

Closed

yury-s mentioned this pull request Mar 19, 2020

[BUG][Chromium] Page.Events.Popup should work with noopener and url crashes browser #1428

Closed

aslushnikov added a commit to aslushnikov/playwright that referenced this pull request Mar 19, 2020

fix type microsoft#2

1ba389c

celeryclub mentioned this pull request Apr 24, 2020

[REGRESSION]: Out of memory errors on 0.15.0 #1968

Closed

yury-s mentioned this pull request Apr 27, 2020

[BUG] 0.15 Cannot launch new chromium context after closing old one #1962

Closed

rat-matheson mentioned this pull request May 28, 2020

[Question] Run playwright from docker container running express server - sandbox issues #2386

Closed

yury-s mentioned this pull request Jun 11, 2020

browser(webkit): add missing wayland library to WPE build #2543

Merged

yury-s mentioned this pull request Jul 6, 2020

browser(webkit): properly disconnect signal handlers when closing browser #2849

Merged

gkushang mentioned this pull request Dec 9, 2020

[BUG] Navigation failed because page crashed! (Javascript tests) #4655

Closed

trieulethe mentioned this pull request Dec 24, 2020

[BUG] No usable sandbox! #4820

Closed

aslushnikov added a commit to aslushnikov/playwright that referenced this pull request May 26, 2021

fix lint microsoft#2

7d51557

pavelfeldman mentioned this pull request Jun 28, 2021

[BUG] File upload crashes on latest release (mac) #7350

Closed

gurjeetbains mentioned this pull request Jul 22, 2021

[Bug]: Playwright Test runner :- Tests not passing test even after all the steps get completed. The browser fails to close #7763

Closed

VincentDondain mentioned this pull request Jul 29, 2021

[Bug]: error TS2339: Property 'waitForEvent' does not exist on type 'SuiteFunction' #7857

Closed

shiv-jirwankar mentioned this pull request Jul 30, 2021

[Question]: page.hover is not working as per the expectation. #7930

Closed

sureshahead mentioned this pull request Sep 22, 2021

[BUG] Dropdown Element selection scrolls up & down (when present in overlay with scroll enabled) #9073

Closed

dgozman mentioned this pull request Oct 22, 2021

[BUG] Test not found error when using async/await calls to fetch data #9636

Closed

vsravuri mentioned this pull request Nov 12, 2021

[BUG] testProject.testMatch |Array<string>| not respecting the order of file names in the array during execution #10150

Closed

dimaBondarenko mentioned this pull request Jul 17, 2022

[Question] Running parallelly two or more test.describe.serial suites that are located in the single file #15741

Closed

Gopala7721 mentioned this pull request Jul 21, 2022

not able to launch the browser inside the docker container #15824

Closed

msabya mentioned this pull request Nov 10, 2022

[BUG]queryByText(id).click() is not working in iphone while its working fine in chromium #18706

Closed

sand4rt referenced this pull request in sand4rt/playwright Dec 21, 2022

chore: style sidebar ul (#2)

9ca240f

shalikaSpringerNature mentioned this pull request Feb 6, 2023

[BUG] custom headers injection is ignored for FireFox & latest playwright Version (1.30) #20614

Closed

quldude mentioned this pull request Mar 17, 2023

[BUG] Javascript __doPostBack missing in browser opened by playwright. #21766

Closed

1 task

sand4rt referenced this pull request in sand4rt/playwright Apr 18, 2023

Merge pull request #2 from sand4rt/ct-code-split-resolve-comments

3b9c5ab

chore(ct): resolve pr comments

CoderWinter121 mentioned this pull request Jun 11, 2023

[BUG]Launch chromium on ubuntu amd64 whih playwright version 1.35.0 failed. #23640

Closed

renovate bot mentioned this pull request Jul 19, 2023

chore(deps): update all non-major dependencies elonehoo/work-talks#14

Closed

1 task

mastacheata mentioned this pull request Jul 24, 2023

[BUG] Can't record trace in a test that opens a download/pdf file #24378

Closed

RomarioNijimAlmond mentioned this pull request Aug 3, 2023

[BUG] - Error: page.goto: net::ERR_CONNECTION_REFUSED at http://127.0.0.1:3000/users/sign_in (local host) #24582

Closed

github-actions bot mentioned this pull request Aug 11, 2023

feat(chromium-tip-of-tree): roll to r1142 #26441

Merged

InduKrish mentioned this pull request Sep 21, 2023

[BUG] scrollIntoViewIfNeeded keeps scrolling thru table even after it scrolled until the element #27214

Closed

iburahim786 mentioned this pull request Oct 20, 2023

[Question] How to get the test results like pass/fail and use it in the afterEach hook #27613

Closed

Dolov mentioned this pull request Oct 24, 2023

Unable to run in AWS lambda #27775

Closed

1 task

dipanjan-it mentioned this pull request Oct 24, 2023

Native App testing capability for IOS & Andriod #27778

Closed

renovate bot mentioned this pull request Nov 29, 2023

chore(deps): update all non-major dependencies stacksjs/stacks#758

Merged

github-actions bot mentioned this pull request Dec 5, 2023

feat(firefox): roll to r1430 #28489

Merged

github-actions bot mentioned this pull request Jan 4, 2024

feat(chromium-tip-of-tree): roll to r1182 #28864

Merged

github-actions bot mentioned this pull request Feb 27, 2024

cherry-pick(#29687): chore: fix docs roll for functions without args follow-up #29688

Merged

tongilcoto mentioned this pull request Apr 8, 2024

[Bug]: Browser object is not restarted after a passed test for two consecutive test.describe #30289

Closed

zeptonaut mentioned this pull request Jun 11, 2024

[BUG] Playwright with Yarn and type: module causes ENOTDIR #16185

Closed

renovate bot mentioned this pull request Jul 16, 2024

chore(deps): update minor and patch qlik-oss/sn-treemap#218

Merged

1 task

github-actions bot mentioned this pull request Aug 27, 2024

chore: generate simple dom descriptions in codegen #32333

Merged

This was referenced Sep 19, 2024

feat(chromium): roll to r1136 #32707

Merged

feat(webkit): roll to r2079 #32720

Merged

feat(webkit): roll to r2080 #32721

Merged

mxschmitt mentioned this pull request Oct 11, 2024

test: fix flaky unselect test #33060

Closed

iKK001 mentioned this pull request Oct 27, 2024

[Bug]: Google Cloud Run deployment not working #33313

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(doc): npm run doc fixed #2

fix(doc): npm run doc fixed #2

pavelfeldman commented Nov 19, 2019

JoelEinbinder Nov 19, 2019

pavelfeldman Nov 19, 2019

JoelEinbinder Nov 19, 2019

		const api = await Source.readFile(path.join(PROJECT_DIR, 'docs', 'api.md'));
		const troubleshooting = await Source.readFile(path.join(PROJECT_DIR, 'docs', 'troubleshooting.md'));

fix(doc): npm run doc fixed #2

fix(doc): npm run doc fixed #2

Conversation

pavelfeldman commented Nov 19, 2019

JoelEinbinder Nov 19, 2019

Choose a reason for hiding this comment

pavelfeldman Nov 19, 2019

Choose a reason for hiding this comment

JoelEinbinder Nov 19, 2019

Choose a reason for hiding this comment