Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(evaluate): serialize map and set (#26730)" #27219

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Revert "feat(evaluate): serialize map and set (#26730)" #27219

merged 1 commit into from
Sep 21, 2023

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Sep 20, 2023

This reverts commit ee203b7.

References #24040.
Fixes #27181.

@github-actions
Copy link
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live

25664 passed, 605 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit b9509b3 into microsoft:main Sep 21, 2023
27 of 28 checks passed
dgozman added a commit to dgozman/playwright that referenced this pull request Sep 21, 2023
@dgozman
cherry-pick(microsoft#27219): Revert "feat(evaluate): serialize map a…
bc675c8 
…nd set (microsoft#26730)"

This reverts commit ee203b7.

References microsoft#24040.
Fixes microsoft#27181.
dgozman added a commit that referenced this pull request Sep 21, 2023
@dgozman
cherry-pick(#27219): Revert "feat(evaluate): serialize map and set (#…
c41012b 
…26730)" (#27222)

This reverts commit ee203b7.

References #24040.
Fixes #27181.
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@dgozman @Germandrummer92
Revert "feat(evaluate): serialize map and set (microsoft#26730)" (mic…
28f8963 
…rosoft#27219)

This reverts commit ee203b7.

References microsoft#24040.
Fixes microsoft#27181.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] evaluate serializing fails at 1.38
2 participants
@dgozman @yury-s