chore: support await using for close() and dispose() #27766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
await_using
branch
from
29abf04
to
1847e38
Compare
dgozman
reviewed
Oct 24, 2023
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
await_using
branch
from
1847e38
to
8bca019
Compare
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
await_using
branch
from
8bca019
to
fdd9275
Compare
Test results for "tests 1"1 failed 7 flaky25975 passed, 604 skipped Merge workflow run. |
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this pull request
Oct 27, 2023
This change assumes that the user has Node 18 with Symbol.dispose available. Fixes microsoft#27141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change assumes that the user has Node 18 with Symbol.dispose available.
Fixes #27141