Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(role): embedded control inside the target element #30403

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Apr 17, 2024

According to the spec, such controls should use the native value as long as they have "aria-label". The relevant spec section is 2D.

However, there is an open issue that claims this should always apply, and all browsers and wpt test actually do that: w3c/accname#64.

Fixes #28848.

According to the spec, such controls should use the native value
as long as they have "aria-label". The relevant spec section is 2D.

However, there is an open issue that claims this should always apply,
and all browsers actually do that: w3c/accname#64
Copy link
Contributor

Test results for "tests 1"

1 flaky ⚠️ [webkit-page] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects

27367 passed, 671 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit 984182b into microsoft:main Apr 17, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] getByRole("heading") can't match name from input value contents
2 participants