Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping to 2E in 2C should not be conditional #64

Open
eps1lon opened this issue Oct 29, 2019 · 0 comments
Open

Skipping to 2E in 2C should not be conditional #64

eps1lon opened this issue Oct 29, 2019 · 0 comments
Milestone

Comments

@eps1lon
Copy link
Contributor

eps1lon commented Oct 29, 2019

Currently we skip to 2E in 2C only if

[...] the current node has an aria-label attribute whose value is not the empty string, nor, when trimmed of white space, is not the empty string:

AND

If traversal of the current node is due to recursion and the current node is an embedded control as defined in step 2E, ignore aria-label and skip to rule 2E.

This means that for an embedded control we would still run 2D if it has an empty aria-label.

<input type="checkbox" id="my-checkbox" />
<label for="my-checkbox">
  Country
  <input type="text" role="combobox" title="Choose country" value="Germany" />
</label>

the accessible name of #my-checkbox would compute to Country Choose Country not Country Germany. It would follow steps

  1. checkbox 2D
  2. label 2F
  3. Text Node 2G
  4. combobox 2D (2C does not apply as it doesn't have an aria-label but a title attribute)

I posted a slightly different markup to the mailing list which is directly taken from the name_heading-combobox-focusable-alternative-manual web-platform-test:

<h2 id="test">
  Country of origin:
  <input role="combobox" type="text" title="Choose your country." value="United States">
</h2>

However, I do not think we should skip to 2E either because while the combobox is a control as defined in 2E it is not embedded in a label.

Opening this as requested by @accdc

@jnurthen jnurthen added this to the 1.2 milestone Oct 31, 2019
dgozman added a commit to dgozman/playwright that referenced this issue Apr 17, 2024
According to the spec, such controls should use the native value
as long as they have "aria-label". The relevant spec section is 2D.

However, there is an open issue that claims this should always apply,
and all browsers actually do that: w3c/accname#64
dgozman added a commit to dgozman/playwright that referenced this issue Apr 17, 2024
According to the spec, such controls should use the native value
as long as they have "aria-label". The relevant spec section is 2D.

However, there is an open issue that claims this should always apply,
and all browsers actually do that: w3c/accname#64
dgozman added a commit to dgozman/playwright that referenced this issue Apr 17, 2024
According to the spec, such controls should use the native value
as long as they have "aria-label". The relevant spec section is 2D.

However, there is an open issue that claims this should always apply,
and all browsers actually do that: w3c/accname#64
dgozman added a commit to microsoft/playwright that referenced this issue Apr 17, 2024
According to the spec, such controls should use the native value as long
as they have "aria-label". The relevant spec section is 2D.

However, there is an open issue that claims this should always apply,
and all browsers and wpt test actually do that:
w3c/accname#64.

Fixes #28848.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants