-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try running audio/video tests on more browsers and platforms #30437
Conversation
@microsoft-github-policy-service agree |
This comment has been minimized.
This comment has been minimized.
cc @mxschmitt I think this needs a tag to run the affected tests. |
This comment has been minimized.
This comment has been minimized.
Done! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@mxschmitt Looks like "tests 2" didn't run when I pushed another commit, and the Installation Test needs to be re-run. Could you help? |
This comment has been minimized.
This comment has been minimized.
@mxschmitt Looks like the "should play audio" and "should play video" tests are flaky on |
Hey @mxschmitt, just following up on this. I pushed a commit to skip the "should play audio" and "should play video" tests on Webkit on macos-12, since that's where I have observed flakiness. Please re-add the label to re-run the tests 😀 |
Test results for "tests 1"1 flaky27249 passed, 670 skipped Merge workflow run. |
@@ -84,8 +83,7 @@ it('should play video @smoke', async ({ page, asset, browserName, platform, mode | |||
}); | |||
|
|||
it('should play webm video @smoke', async ({ page, asset, browserName, platform, mode }) => { | |||
it.fixme(browserName === 'webkit' && platform === 'darwin' && parseInt(os.release(), 10) === 20, 'Does not work on BigSur'); | |||
it.fixme(browserName === 'webkit' && platform === 'win32'); | |||
it.fixme(browserName === 'webkit' && platform !== 'darwin'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this means it doesn't work on linux?
it.fixme(browserName === 'firefox' && platform === 'win32', 'https://github.com/microsoft/playwright/issues/10887'); | ||
it.fixme(browserName === 'firefox' && platform === 'linux', 'https://github.com/microsoft/playwright/issues/10887'); | ||
it.fixme(browserName === 'webkit' && platform === 'win32', 'https://github.com/microsoft/playwright/issues/10892'); | ||
it.fixme(browserName === 'webkit' && platform !== 'darwin'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wasn't fixme on linux before?
lets try to stick with === rather than !== I think thats easier to read.
Re-triggered the bot. Also landed this #30634 which should make things simpler (I think it doesn't work for macOS 12 / maybe 13 but does a good job for 14). |
Test results for "tests 2"6 fatal errors, not part of any test 48 flaky167883 passed, 7560 skipped, 3960 did not run Merge workflow run. |
Archiving this |
I'm trying to debug a Playwright issue with
AudioContext
on Windows runners (will file a separate issue if I can't figure it out), and I'm interested to see if Playwright's audio/video tests now work on all platforms and browsers.This PR removes some
it.fixme
annotations from the audio/video tests incapabilities.spec.ts
. All theit.fixme
lines I removed were added more than a year ago, and all the linked issues look like they are resolved.Related: #30410