Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove obsolete Chromium enabled features #31513

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

KuSh
Copy link
Contributor

@KuSh KuSh commented Jul 2, 2024

The "NetworkService" chromium feature has been removed since Jan 2022, see https://crrev.com/c/3417192.
The "NetworkServiceInProcess" chromium feature has been renamed since May 2022, see https://crrev.com/c/3647768.

And the new NetworkServiceInProcess2 flag might lead to crashes in latest versions of desktop Chrome according to puppeteer/puppeteer#12261

Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Test results for "tests 1"

7 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture

28409 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit 9caf3b5 into microsoft:main Jul 2, 2024
30 checks passed
@KuSh KuSh deleted the patch-1 branch July 2, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants