fix(cors): allow routing the cors request with credentials #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
cors_credentials
branch
from
d17a9da
to
ec8638e
Compare
pavelfeldman
force-pushed
the
cors_credentials
branch
from
ec8638e
to
2b7bdc8
Compare
dgozman
approved these changes
Aug 7, 2020
|
@dgozman @pavelfeldman Could you add an example of how to use this? How to do a route and then respond with some mocked headers. Thanks! |
|
+1 for an example here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the use-case behind #3331. It does not expose explicit OPTIONS routing, but allows the credentials CORS requests to be routed.