browser(webkit): disable accelerated compositing on Windows #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
approved these changes
Aug 8, 2020
yury-s
added a commit
to yury-s/playwright
that referenced
this pull request
Sep 4, 2020
pavelfeldman
pushed a commit
that referenced
this pull request
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yury-s/WebKit@52409f0
"WinCairo AC is pretty immature yet. LayerTreeHost::setShouldNotifyAfterNextScheduledLayerFlush in LayerTreeHostTextureMapper.cpp is not implemented yet." (from #windows WebKit slack channel) This leads to inconsistent state between UI and Web processes when Web Page gets into accelerated compositing mode and UI process doesn't know about it. This makes screencast pick wrong mode and not record actual picture.
#1158