feat(har): allow saving HAR 1.2 for context #4214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
changed the title
mxschmitt
reviewed
Oct 22, 2020
pavelfeldman
force-pushed
the
har2
branch
4 times, most recently
from
5254f1f
to
9e1f061
Compare
pavelfeldman
force-pushed
the
har2
branch
2 times, most recently
from
f1285cb
to
5f795db
Compare
| }), true, undefined).then(result => { | ||
| pageEntry.title = result.title; | ||
| pageEntry.pageTimings.onContentLoad = result.domContentLoaded; | ||
| }).catch(() => {}); |
There was a problem hiding this comment.
Everything without await has a catch...
JoelEinbinder
approved these changes
Oct 26, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not yet contain headers / body size. I can estimate them, but I know that people are typically interested in the accurate numbers and we can do that with a number of browser patches, so leaving them -1 for now. HAR 1.2 allows that...