browser(webkit): change scrollIntoView to only scroll if needed #5079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have alignCenterAlways to workaround the RenderLayer logic that does not scroll horizontally if enough of the element is visible. This change plumbs the bit "avoid minimum threshold" in the ScrollAlignment. This way, we don't actually scroll when the desired rect is already visible and prevent overlay scrollbars flashing that block pointer actions on MacOS.
yury-s
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have alignCenterAlways to workaround the RenderLayer logic
that does not scroll horizontally if enough of the element is visible.
This change plumbs the bit "avoid minimum threshold" in the
ScrollAlignment. This way, we don't actually scroll when the desired
rect is already visible and prevent overlay scrollbars flashing that
block pointer actions on MacOS.