Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser(webkit): change scrollIntoView to only scroll if needed #5079

Merged
merged 1 commit into from
Jan 21, 2021
Merged

browser(webkit): change scrollIntoView to only scroll if needed #5079

merged 1 commit into from
Jan 21, 2021

Commits on Jan 21, 2021

  1. browser(webkit): change scrollIntoView to only scroll if needed 

    We used to have alignCenterAlways to workaround the RenderLayer logic
that does not scroll horizontally if enough of the element is visible.

This change plumbs the bit "avoid minimum threshold" in the
ScrollAlignment. This way, we don't actually scroll when the desired
rect is already visible and prevent overlay scrollbars flashing that
block pointer actions on MacOS.
    @dgozman
    dgozman committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    7604389 View commit details
    Browse the repository at this point in the history