Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trace][feature] Add trace usage telemetry #3368

Merged
merged 12 commits into from
Jun 6, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Jun 3, 2024

Description

This PR targets to add trace usage telemetry in custom dimensions, which looks like below:

image

There will be a thread scheduled to flush trace telemetry in memory - different process worker stores telemetry in different process, so it's difficult to flush for each, so a scheduled thread shall work best in this case.

Besides, fixes a replay test introduced in #3348 , which changes test class init signature, and leads to our replay tests breaking.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Jun 3, 2024

promptflow SDK CLI Azure E2E Test Result zhengfei/feature/trace-telemetry

  4 files    4 suites   4m 15s ⏱️
243 tests 203 ✅  40 💤 0 ❌
972 runs  812 ✅ 160 💤 0 ❌

Results for commit b7f04d4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 3, 2024

SDK CLI Global Config Test Result zhengfei/feature/trace-telemetry

6 tests   6 ✅  1m 15s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit b7f04d4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 3, 2024

Executor Unit Test Result zhengfei/feature/trace-telemetry

796 tests   796 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit b7f04d4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 3, 2024

Executor E2E Test Result zhengfei/feature/trace-telemetry

246 tests   240 ✅  5m 19s ⏱️
  1 suites    6 💤
  1 files      0 ❌

Results for commit b7f04d4.

♻️ This comment has been updated with latest results.

@zhengfeiwang zhengfeiwang requested a review from huaiyan June 3, 2024 10:52
Copy link

github-actions bot commented Jun 3, 2024

SDK CLI Test Result zhengfei/feature/trace-telemetry

    4 files      4 suites   1h 6m 12s ⏱️
  784 tests   764 ✅ 20 💤 0 ❌
3 136 runs  3 056 ✅ 80 💤 0 ❌

Results for commit b7f04d4.

♻️ This comment has been updated with latest results.

@wangchao1230 wangchao1230 merged commit ab3f142 into main Jun 6, 2024
41 checks passed
@wangchao1230 wangchao1230 deleted the zhengfei/feature/trace-telemetry branch June 6, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants