Replace mlflow and azure-mlflow by custom code. #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irovins/remove_mlflow_dep
…irovins/remove_mlflow_dep
…irovins/remove_mlflow_dep
SDK CLI Test Result nirovins/remove_mlflow_dep 4 files 4 suites 1h 6m 36s ⏱️ Results for commit 1dcf2c2. ♻️ This comment has been updated with latest results. |
luigiw
approved these changes
Jun 10, 2024
crazygao
approved these changes
Jun 11, 2024
7 tasks
wangchao1230
pushed a commit
that referenced
this pull request
Jun 12, 2024
# Description #3390 introduces some sanitizations, which breaks `promptflow-azure` replay test. This PR targets to add an environment variable to distinguish `promptflow-azure` and `promptflow-evals`. Besides, make `promptflow-azure` replay test listen on pf-recording code path to avoid such breaking. # All Promptflow Contribution checklist: - [x] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [x] Title of the pull request is clear and informative. - [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [x] Pull request includes test coverage for the included changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we are replacing the mlflow dependencies by custom code. To record the tests, the appropriate changes in promptflow-recording were made. See work item 3250528.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines