Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reported training loss when using AMP #17

Merged
merged 1 commit into from
Jul 25, 2021

Conversation

mallamanis
Copy link
Contributor

  • Scaling has to happen after reporting the loss to be accurate.
  • Also avoid GPU->CPU transfer of the minibatch loss during each iteration.

@mallamanis mallamanis self-assigned this Jul 25, 2021
@mallamanis mallamanis merged commit 6c55894 into master Jul 25, 2021
@mallamanis mallamanis deleted the dev/miallama/fix-training-loss-scaling branch July 25, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant