This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
"runInTerminal" is broken on non-Windows platforms #1721
Assignees
Milestone
Comments
|
Done |
int19h
added a commit
to int19h/ptvsd
that referenced
this issue
Sep 6, 2019
…disconnect Fix microsoft#1721 "runInTerminal" is broken on non-Windows platforms. Fix microsoft#1722: Output is not captured in "noDebug" with "runInTerminal" Groundwork for microsoft#1713: adapter: multiple concurrent sessions Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel. Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session. Improve adapter logging to capture information about current debug session, and current message handler if any. Fix reporting exceptions from message handlers.
int19h
added a commit
to int19h/ptvsd
that referenced
this issue
Sep 7, 2019
…disconnect Fix microsoft#1721 "runInTerminal" is broken on non-Windows platforms. Fix microsoft#1722: Output is not captured in "noDebug" with "runInTerminal" Groundwork for microsoft#1713: adapter: multiple concurrent sessions Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel. Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session. Improve adapter logging to capture information about current debug session, and current message handler if any. Fix reporting exceptions from message handlers.
int19h
added a commit
to int19h/ptvsd
that referenced
this issue
Sep 8, 2019
…disconnect Fix microsoft#1721 "runInTerminal" is broken on non-Windows platforms. Fix microsoft#1722: Output is not captured in "noDebug" with "runInTerminal" Groundwork for microsoft#1713: adapter: multiple concurrent sessions Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel. Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session. Improve adapter logging to capture information about current debug session, and current message handler if any. Fix reporting exceptions from message handlers.
int19h
added a commit
to int19h/ptvsd
that referenced
this issue
Sep 10, 2019
…disconnect Fix microsoft#1721 "runInTerminal" is broken on non-Windows platforms. Fix microsoft#1722: Output is not captured in "noDebug" with "runInTerminal" Groundwork for microsoft#1713: adapter: multiple concurrent sessions Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel. Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session. Improve adapter logging to capture information about current debug session, and current message handler if any. Fix reporting exceptions from message handlers. Various test fixes.
int19h
added a commit
to int19h/ptvsd
that referenced
this issue
Sep 10, 2019
…disconnect Fix microsoft#1721 "runInTerminal" is broken on non-Windows platforms. Fix microsoft#1722: Output is not captured in "noDebug" with "runInTerminal" Groundwork for microsoft#1713: adapter: multiple concurrent sessions Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel. Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session. Improve adapter logging to capture information about current debug session, and current message handler if any. Fix reporting exceptions from message handlers. Various test fixes.
int19h
added a commit
to int19h/ptvsd
that referenced
this issue
Sep 10, 2019
…disconnect Fix microsoft#1721 "runInTerminal" is broken on non-Windows platforms. Fix microsoft#1722: Output is not captured in "noDebug" with "runInTerminal" Groundwork for microsoft#1713: adapter: multiple concurrent sessions Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel. Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session. Improve adapter logging to capture information about current debug session, and current message handler if any. Fix reporting exceptions from message handlers. Various test fixes.
int19h
added a commit
to int19h/ptvsd
that referenced
this issue
Sep 10, 2019
…disconnect Fix microsoft#1721 "runInTerminal" is broken on non-Windows platforms. Fix microsoft#1722: Output is not captured in "noDebug" with "runInTerminal" Groundwork for microsoft#1713: adapter: multiple concurrent sessions Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel. Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session. Improve adapter logging to capture information about current debug session, and current message handler if any. Fix reporting exceptions from message handlers. Various test fixes.
int19h
added a commit
to int19h/ptvsd
that referenced
this issue
Sep 10, 2019
…disconnect Fix microsoft#1721 "runInTerminal" is broken on non-Windows platforms. Fix microsoft#1722: Output is not captured in "noDebug" with "runInTerminal" Groundwork for microsoft#1713: adapter: multiple concurrent sessions Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel. Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session. Improve adapter logging to capture information about current debug session, and current message handler if any. Fix reporting exceptions from message handlers. Various test fixes.
int19h
added a commit
to int19h/ptvsd
that referenced
this issue
Sep 10, 2019
…disconnect Fix microsoft#1721 "runInTerminal" is broken on non-Windows platforms. Fix microsoft#1722: Output is not captured in "noDebug" with "runInTerminal" Groundwork for microsoft#1713: adapter: multiple concurrent sessions Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel. Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session. Improve adapter logging to capture information about current debug session, and current message handler if any. Fix reporting exceptions from message handlers. Various test fixes.
int19h
added a commit
to int19h/ptvsd
that referenced
this issue
Sep 10, 2019
…disconnect Fix microsoft#1721 "runInTerminal" is broken on non-Windows platforms. Fix microsoft#1722: Output is not captured in "noDebug" with "runInTerminal" Groundwork for microsoft#1713: adapter: multiple concurrent sessions Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel. Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session. Improve adapter logging to capture information about current debug session, and current message handler if any. Fix reporting exceptions from message handlers. Various test fixes.
int19h
added a commit
that referenced
this issue
Sep 10, 2019
Fix #1721 "runInTerminal" is broken on non-Windows platforms. Fix #1722: Output is not captured in "noDebug" with "runInTerminal" Groundwork for #1713: adapter: multiple concurrent sessions Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel. Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session. Improve adapter logging to capture information about current debug session, and current message handler if any. Fix reporting exceptions from message handlers. Various test fixes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
(dbg_adapter_refactor branch)
On platforms other than Win32,
os.waitpid()cannot be used to wait on a process that isn't a child process, to obtain its exit code. When the process is launched via "runInTerminal" request, it is a child process of VSCode, not a child process of the adapter. Thus, the adapter cannot track those processes, and cannot detect when they exit in nodebug scenario, since there's no connection.The launcher needs to keep track of the process instead, and notify the adapter.
The text was updated successfully, but these errors were encountered: