Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1695, #1721, #1722, some of #1713 #1757

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@int19h
Copy link
Contributor

commented Sep 10, 2019

Fix #1695: Handle IDE, launcher, debug server, and no-debug disconnect

Fix #1721 "runInTerminal" is broken on non-Windows platforms.

Fix #1722: Output is not captured in "noDebug" with "runInTerminal"

Groundwork for #1713: adapter: multiple concurrent sessions

Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel.

Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session.

Improve adapter logging to capture information about current debug session, and current message handler if any.

Fix reporting exceptions from message handlers.

Various test fixes.

@int19h int19h requested a review from karthiknadig Sep 10, 2019

@int19h int19h force-pushed the int19h:1721 branch 4 times, most recently from 1b506b6 to 56735d4 Sep 10, 2019

@karthiknadig
Copy link
Member

left a comment

:shipit:

Fix #1695: Handle IDE, launcher, debug server, and no-debug disconnect
Fix #1721 "runInTerminal" is broken on non-Windows platforms.

Fix #1722: Output is not captured in "noDebug" with "runInTerminal"

Groundwork for #1713: adapter: multiple concurrent sessions

Move "launch" request parsing and debuggee process spawning, PID reporting and tracking, stdio "output" capture, and exit code reporting into launcher. Launcher now communicates to the adapter via a full-fledged message channel.

Refactor adapter. Add an abstraction for a debug session, and treat IDE, launcher, and debug server as separate components managed by that session.

Improve adapter logging to capture information about current debug session, and current message handler if any.

Fix reporting exceptions from message handlers.

Various test fixes.

@int19h int19h force-pushed the int19h:1721 branch from 56735d4 to f239752 Sep 10, 2019

@int19h int19h merged commit 340942a into microsoft:dbg_adapter_refactor Sep 10, 2019

1 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ptvsd-pypy-tests #20190910.3 failed
Details
ptvsd-testing-automation #20190910.3 failed
Details
license/cla All CLA requirements met.
Details

@int19h int19h deleted the int19h:1721 branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.