Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

ptvsd.break_into_debugger not breaking at the right place #501

Closed
DonJayamanne opened this issue Jun 19, 2018 · 4 comments
Closed

ptvsd.break_into_debugger not breaking at the right place #501

DonJayamanne opened this issue Jun 19, 2018 · 4 comments

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jun 19, 2018

import ptvsd
import time
ptvsd.enable_attach()
ptvsd.wait_for_attach()
time.sleep(2)
ptvsd.break_into_debugger()
print("Hello world")
  • Run the above code
  • Attach the debugger in VSC
  • Debugger breaks at the wrong, place.
    It breaks in urllib/parse.py line 745:
def quote(string, safe='/', encoding=None, errors=None):
    """quote('abc def') -> 'abc%20def'

This used to work in PTVSD 4.1.1a5
Most likely related to #462

@DonJayamanne DonJayamanne self-assigned this Jun 19, 2018
@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Jun 19, 2018

The commit d635e22 is what has introduced this bug.

/cc @karthiknadig @fabioz
If we test PTVSD prior to the above commit, things were fine, however after that, we have either one of the two issues:

  • Breaking into debugger doesn't work
  • Or if we add a delay time.slee (as above), then it breaks at the wrong place.

Note: This is related to #462

@fabioz
Copy link
Contributor

fabioz commented Jun 20, 2018

I'll take a look at this.

fabioz added a commit to fabioz/ptvsd that referenced this issue Jun 20, 2018
fabioz added a commit to fabioz/ptvsd that referenced this issue Jun 20, 2018
fabioz added a commit to fabioz/ptvsd that referenced this issue Jun 20, 2018
fabioz added a commit to fabioz/ptvsd that referenced this issue Jun 20, 2018
fabioz added a commit to fabioz/ptvsd that referenced this issue Jun 20, 2018
@fabioz
Copy link
Contributor

fabioz commented Jun 20, 2018

Pull request #508 should fix the part related to pydevd.

@DonJayamanne
Copy link
Contributor Author

Sorry, fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants