Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Pausing (break) not working anymore in VSC #479

Closed
DonJayamanne opened this issue Jun 14, 2018 · 3 comments
Closed

Pausing (break) not working anymore in VSC #479

DonJayamanne opened this issue Jun 14, 2018 · 3 comments
Labels
Bug Upstream-pydevd
Milestone
June 2018.2

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jun 14, 2018 •
edited
Loading

We have unit tests that have caught this error.

Been ignoring failing Debugger tests in VSC as we have had a number of failing debugger tests for over a month, hence I have no idea when this issue cropped up. Either way this is something that used to work (still works in the preview version of PTVSD on pypi).

screen shot 2018-06-13 at 5 42 57 pm

Steps to reproduce:

  • Create a python file with the following code:
import time

for i in range(1000):
    time.sleep(1)
    print(i)
  • Start debugging without any breakpoints
  • Once started printing to console window, hit the Pause button.
  • Nothing happens
@DonJayamanne DonJayamanne mentioned this issue Jun 14, 2018
Closed
@DonJayamanne
Copy link
Contributor Author

Looks like d635e22 has introduced this issue.

/cc @karthiknadig @fabioz

@fabioz
Copy link
Contributor

fabioz commented Jun 20, 2018

Pull request #508 should fix this too.

fabioz added a commit to fabioz/ptvsd that referenced this issue Jun 20, 2018
@fabioz
Make sure that the stepping command is properly set when a thread is …
2c0f9f2 
…suspended. Fixes microsoft#501, microsoft#479
@karthiknadig karthiknadig added this to the June 2018.2 milestone Jun 20, 2018
karthiknadig pushed a commit that referenced this issue Jun 21, 2018
@fabioz @karthiknadig
Fix for #501 and #479 (issues related to pausing a thread with debugg…
fb27b41 
…er.set_suspend) (#508)

* Fix issue where pydevd threads could end up being traced.

* Make sure that the stepping command is properly set when a thread is suspended. Fixes #501, #479
@karthiknadig
Copy link
Member

This is fixed. Tested on windows with VSC.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Upstream-pydevd
Projects
None yet
Milestone
June 2018.2
Development

No branches or pull requests
3 participants
@fabioz @DonJayamanne @karthiknadig