This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Support for terminate and terminateDebuggee. Fixes #1755 #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int19h
reviewed
Sep 11, 2019
| if IS_WINDOWS: | ||
| self._terminate_process_and_children_windows() | ||
| else: | ||
| self._terminate_process_and_children_linux_and_mac() |
There was a problem hiding this comment.
My suggestion would be to make these handle the children only (conditional on the flag), and then wrap the call in a try..finally that does os._exit at the end. This way, if anything goes wrong while processing the subprocess tree, at least the process itself definitely exits.
The main reason is that the code that deals with children itself spawns another process and then communicates with it, and that can fail in so many ways - e.g. the helper process can spawn successfully but then crash.
|
This fixes #1715 as well. |
int19h
approved these changes
Sep 12, 2019
fabioz
force-pushed
the
rb_ptvsd_1755_terminate
branch
from
5f01bfc
to
b931410
Compare
fabioz
force-pushed
the
rb_ptvsd_1755_terminate
branch
from
b931410
to
e83abac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.