-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable extensions where fixes have been applied #3769
Conversation
Re-enable extensions where fixes have been applied
targetconfig.json
Outdated
@@ -221,11 +221,11 @@ | |||
"alsrobot-microbit-makecode-packages/cruisebit": "dv:mbcodal", | |||
"tinkertanker/udriver_pca9585": "dv:mbcodal", | |||
"dfrobot/pxt-dfrobot-naturalscience": "dv:mbcodal", | |||
"kitronikltd/pxt-kitronik-zip-tile": "min:1.0.2", | |||
"4tronix/bitcommander": "min:1.0.2", | |||
"kitronikltd/pxt-kitronik-zip-tile": "min:0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be min:v0.1.0 right? Tag has v in front of it. Please check the others as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was taking the version from https://github.com/KitronikLtd/pxt-kitronik-zip-tile/blob/85d5c24d15648458770ea47b0b61949cd65a3581/pxt.json#L3 should it be the tagged release as in https://github.com/KitronikLtd/pxt-kitronik-zip-tile/releases/tag/v0.1.0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 5af55f7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abchatra is this now ok?
Re-enable extensions where fixes have been applied.
We can add these per extension/vendor in future, just getting through the first few.