Re-enable extensions where fixes have been applied #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-enable extensions where fixes have been applied
microbit-mark
changed the title
abchatra
requested changes
Nov 25, 2020
targetconfig.json
Outdated
| @@ -221,11 +221,11 @@ | |||
| "alsrobot-microbit-makecode-packages/cruisebit": "dv:mbcodal", | |||
| "tinkertanker/udriver_pca9585": "dv:mbcodal", | |||
| "dfrobot/pxt-dfrobot-naturalscience": "dv:mbcodal", | |||
| "kitronikltd/pxt-kitronik-zip-tile": "min:1.0.2", | |||
| "4tronix/bitcommander": "min:1.0.2", | |||
| "kitronikltd/pxt-kitronik-zip-tile": "min:0.1.0", | |||
There was a problem hiding this comment.
This should be min:v0.1.0 right? Tag has v in front of it. Please check the others as well.
There was a problem hiding this comment.
I was taking the version from https://github.com/KitronikLtd/pxt-kitronik-zip-tile/blob/85d5c24d15648458770ea47b0b61949cd65a3581/pxt.json#L3 should it be the tagged release as in https://github.com/KitronikLtd/pxt-kitronik-zip-tile/releases/tag/v0.1.0 ?
There was a problem hiding this comment.
Updated in 5af55f7
There was a problem hiding this comment.
@abchatra is this now ok?
abchatra
approved these changes
Dec 1, 2020
abchatra
approved these changes
Dec 1, 2020
abchatra
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable extensions where fixes have been applied.
We can add these per extension/vendor in future, just getting through the first few.