Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't double toggle #5658

Merged
merged 8 commits into from
Jun 10, 2019
Merged

Don't double toggle #5658

merged 8 commits into from
Jun 10, 2019

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Jun 10, 2019 •
edited
Loading

Fix for microsoft/pxt-microbit#2172

  • use "showHint" instead of "toggle" to be more intentional about which state needs to be enabled
  • avoid double toggle by unregistering the hintOnClick between steps

@pelikhan pelikhan requested review from shakao and abchatra June 10, 2019 16:31
@pelikhan pelikhan requested review from shakao and abchatra June 10, 2019 16:37
@pelikhan pelikhan merged commit ccecda0 into master Jun 10, 2019
@pelikhan pelikhan deleted the togglehint branch June 10, 2019 17:01
JacobBovee pushed a commit that referenced this pull request Jun 10, 2019
@pelikhan @JacobBovee
Don't double toggle (#5658)
6251825 
* show instead of toggle for more precision

* fix refactoring

* add check for leaks

* stop propagation after check

* unregist hintonclick when changing step

* handle vis

* unregister when hint missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakao shakao shakao approved these changes

@abchatra abchatra Awaiting requested review from abchatra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pelikhan @shakao