Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a section on the new melody features from klaus to release notes #7844

Merged
merged 5 commits into from Feb 2, 2021

Conversation

jwunderl
Copy link
Member

Add a section with some notes on the improvements to the sound & thanks.

(@klausw in case I misrepresented any of the changes, the changes were a little while ago so I might have missed some subtleties when reviewing them. And thanks again!)

Copy link
Collaborator

@ganicke ganicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the RTrim on those lines too!

Co-authored-by: Galen Nickel <v-gani@microsoft.com>
@klausw
Copy link
Contributor

klausw commented Jan 29, 2021

Thanks! FYI, I just posted microsoft/pxt-arcade#3002 which adds the new waveforms to the documentation. If that gets merged, maybe consider linking to it from the changelog?

Copy link
Member

@Jaqster Jaqster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Jaqster
Copy link
Member

Jaqster commented Jan 29, 2021

By the way @klausw - my kids and I just spent the last 15 minutes playing around with your new sounds! https://arcade.makecode.com/91960-59425-02296-62940 They're so awesome!!! THANK YOU :-)

@jwunderl
Copy link
Member Author

@klausw That PR looks good too! We working through some build issues right now so might have to wait until tomorrow to get both of these docs changes in, but I've updated the attribution ~

@klausw
Copy link
Contributor

klausw commented Jan 29, 2021

@klausw That PR looks good too! We working through some build issues right now so might have to wait until tomorrow to get both of these docs changes in, but I've updated the attribution ~

Thank you! Just to avoid misunderstandings, I wasn't asking for that change to get called out specifically, what I meant was that it may be useful to add a link to https://arcade.makecode.com/developer/sound as a pointer for people who want to experiment with the additions.

By the way @klausw - my kids and I just spent the last 15 minutes playing around with your new sounds! https://arcade.makecode.com/91960-59425-02296-62940 They're so awesome!!! THANK YOU :-)

Glad to hear it! I'm currently adding a few more that could be useful for games, I'll update the forum thread once I have something to show.

@jwunderl jwunderl merged commit 64f8f52 into master Feb 2, 2021
@jwunderl jwunderl deleted the updateWKlausThanks branch February 2, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants