Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset editor for non-arcade targets #9878

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Feb 22, 2024

This fixes the image editor for non-arcade targets like micro:bit and minecraft (the pixel art extension)

Includes three fixes:

  1. Removes the name field from the bottom bar of the asset editor when assetEditor isn't set in pxtarget.json
  2. Fixes palettes loading from pxt.json when using compile variants (i.e. in micro:bit)
  3. Hides the gallery tab in the image editor when there are no gallery assets

@riknoll riknoll requested review from tballmsft and a team February 22, 2024 19:01
Copy link
Contributor

@tballmsft tballmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, Richard!

Copy link
Contributor

@srietkerk srietkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@riknoll riknoll merged commit 993ca5b into master Feb 23, 2024
7 checks passed
@riknoll riknoll deleted the dev/riknoll/image-editor-hide-name branch February 23, 2024 18:47
riknoll added a commit that referenced this pull request May 17, 2024
…necraft stable (#10009)

* [stable9.0] Cherry picking crowdin changes over to Calliope's stable branch (#9991)

* [V9] Cherry picking crowdin work over to v9 branch (#9963)

* Upgrade to Crowdin V2 APIs (#9954)

* use crowdin v2 apis

* rename crowdin API

* add projectid setting

* fix test mode

* copy pxt-translations crowdin config

* re-enable crowdin stats (#9962)

* Add restore command and keep translations when updating (#9966) (#9968)

* add restore command and keep translations when updating

* add --test flag

* add parameter to prevent accidental runs

* hide asset name when assetEditor is false (#9878)

* Fixes for image editor in micro:bit (#9900)

* fix compile variants when palette is in dep

* add field editor param for the tagged template

* fix help link in monaco flyout (#10008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants