Upgrade to Crowdin V2 APIs #9954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup not used |
|
My scripts use their cli |
jwunderl
approved these changes
Apr 9, 2024
|
Gonna tag this one to close #9539 |
riknoll
added a commit
that referenced
this pull request
Apr 11, 2024
* use crowdin v2 apis * rename crowdin API * add projectid setting * fix test mode * copy pxt-translations crowdin config
riknoll
added a commit
that referenced
this pull request
Apr 11, 2024
riknoll
added a commit
that referenced
this pull request
Apr 30, 2024
riknoll
added a commit
that referenced
this pull request
Apr 30, 2024
…branch (#9991) * [V9] Cherry picking crowdin work over to v9 branch (#9963) * Upgrade to Crowdin V2 APIs (#9954) * use crowdin v2 apis * rename crowdin API * add projectid setting * fix test mode * copy pxt-translations crowdin config * re-enable crowdin stats (#9962) * Add restore command and keep translations when updating (#9966) (#9968) * add restore command and keep translations when updating * add --test flag * add parameter to prevent accidental runs
riknoll
added a commit
that referenced
this pull request
May 8, 2024
…branch (#9991) * [V9] Cherry picking crowdin work over to v9 branch (#9963) * Upgrade to Crowdin V2 APIs (#9954) * use crowdin v2 apis * rename crowdin API * add projectid setting * fix test mode * copy pxt-translations crowdin config * re-enable crowdin stats (#9962) * Add restore command and keep translations when updating (#9966) (#9968) * add restore command and keep translations when updating * add --test flag * add parameter to prevent accidental runs
riknoll
added a commit
that referenced
this pull request
May 17, 2024
…necraft stable (#10009) * [stable9.0] Cherry picking crowdin changes over to Calliope's stable branch (#9991) * [V9] Cherry picking crowdin work over to v9 branch (#9963) * Upgrade to Crowdin V2 APIs (#9954) * use crowdin v2 apis * rename crowdin API * add projectid setting * fix test mode * copy pxt-translations crowdin config * re-enable crowdin stats (#9962) * Add restore command and keep translations when updating (#9966) (#9968) * add restore command and keep translations when updating * add --test flag * add parameter to prevent accidental runs * hide asset name when assetEditor is false (#9878) * Fixes for image editor in micro:bit (#9900) * fix compile variants when palette is in dep * add field editor param for the tagged template * fix help link in monaco flyout (#10008)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading our Crowdin support to use the V2 APIs.
I've done a little bit of testing and things seems to be running as they should. I was able to download strings from arcade and upload a few (unchanged) files to pxt-ev3. In any case, this is safe to merge since we don't have any updated API tokens in place. I plan to test this with pxt-ev3 first since that target has fewer eyes on it.
This PR also removes support for crowdin branches. AFAIK we don't actually use them anywhere (@pelikhan correct me if I'm wrong) and they are not compatible with the directory based structure in the V2 api, so I don't expect this to be an issue. I still need to pull out a lot of references to crowdin branches in the code but I'll do that in a separate PR.
Also, I have temporarily disabled the
pxt crowdin statscommand but I've got a plan to bring it back.