Skip to content
This repository has been archived by the owner on Apr 14, 2022. It is now read-only.

Single-element tuple assignments have no type information #411

Closed
jakebailey opened this issue Nov 19, 2018 · 1 comment · Fixed by #1553
Closed

Single-element tuple assignments have no type information #411

jakebailey opened this issue Nov 19, 2018 · 1 comment · Fixed by #1553
Assignees
@CTrando
Labels
gen from the generated tests

Comments

@jakebailey
Copy link
Member

jakebailey commented Nov 19, 2018 •
edited
Loading

When the LHS is a tuple with a single item, the assigned type is not propagated. Examples:

(foo) = 1234
((x, y)) = 1, "2"

foo, x, and y all do not have known types.

Found in #334.
@MikhailArkhipov MikhailArkhipov self-assigned this Feb 19, 2019
CTrando added a commit to CTrando/python-language-server that referenced this issue Sep 2, 2019
@CTrando
Handling microsoft#411 as well
c61ab48
@CTrando CTrando mentioned this issue Sep 3, 2019
Merged
@CTrando CTrando assigned CTrando and unassigned MikhailArkhipov Sep 4, 2019
@jakebailey jakebailey added the gen from the generated tests label Sep 11, 2019
MikhailArkhipov pushed a commit that referenced this issue Sep 16, 2019
@CTrando
Unpacking typing Tuples and Lists correctly (#1498)
52e4beb 
* Handling unpacking with typing structures

* Removing changes to value enumerator

* Test fix, formatting

* Refactors

* Handling nested structures

* Handles non typing lists and tuples

* Giving up on fixing root problem, adding hack

* test fix

* Reverting change to test and fixing test

* Update syntax

* Checking #1494

* Handling #411 as well

* multiple assignment + unpacking fixes #1293

* Handling more cases with unpacking nested tuples

* merge fixes

* No default param for arg set, force people to use something
@MikhailArkhipov MikhailArkhipov mentioned this issue Sep 16, 2019
Merged
MikhailArkhipov pushed a commit that referenced this issue Sep 16, 2019
Unpacking typing Tuples and Lists correctly (#1553)
57a9a43 
Fixes #1457
Fixes #1494
Fixes #411
Fixes #1382
Fixes #1293
@MikhailArkhipov
Copy link

0.4.18+

jakebailey pushed a commit to jakebailey/python-language-server that referenced this issue Nov 1, 2019
Unpacking typing Tuples and Lists correctly (microsoft#1553)
fdb2562 
Fixes microsoft#1457
Fixes microsoft#1494
Fixes microsoft#411
Fixes microsoft#1382
Fixes microsoft#1293
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@CTrando CTrando

Labels
gen from the generated tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unpacking typing Tuples and Lists correctly microsoft/python-language-server
3 participants
@jakebailey @MikhailArkhipov @CTrando