Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base config in yml #1500

Merged
merged 27 commits into from
May 12, 2023
Merged

Conversation

Fivele-Li
Copy link
Contributor

add baseConfig in yml,user can add new keys or update/drop keys in baseConfig;

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@github-actions github-actions bot added the waiting for triage Cannot auto-triage, wait for triage. label Apr 21, 2023
@Fivele-Li
Copy link
Contributor Author

It looks good but could be so much simpler

How do you think we can write this feature in a more simple way?

@you-n-g you-n-g merged commit 7234308 into microsoft:main May 12, 2023
@you-n-g you-n-g added enhancement New feature or request and removed waiting for triage Cannot auto-triage, wait for triage. labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants