Validation for entry points (#204)

.gitignore

@@ -330,3 +330,4 @@ ASALocalRun/
 # MFractors (Xamarin productivity tool) working folder 
 .mfractor/
 /src/QsCompiler/TestTargets/Simulation/Example/generated
+/src/ProjectTemplates/.vscode

src/QsCompiler/CommandLineTool/CommandLineTool.csproj

@@ -25,7 +25,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="CommandLineParser" Version="2.2.1" />
+    <PackageReference Include="CommandLineParser" Version="2.6.0" />
   </ItemGroup>
 
   <ItemGroup>

src/QsCompiler/CompilationManager/CompilationUnit.cs

@@ -92,7 +92,7 @@ private static IEnumerable<TypeDeclarationHeader> TypeHeaders(IEnumerable<(strin
         /// Throws an ArgumentNullException if the given dictionary of references is null. 
         /// Throws an ArgumentException if the given set shares references with the current one. 
         /// </summary>
-        internal References CombineWith(References other, Action<ErrorCode, string[]> onError)
+        internal References CombineWith(References other, Action<ErrorCode, string[]> onError = null)
         {
             if (other == null) throw new ArgumentNullException(nameof(other));
             if (this.Declarations.Keys.Intersect(other.Declarations.Keys).Any()) throw new ArgumentException("common references exist");
@@ -106,7 +106,7 @@ internal References CombineWith(References other, Action<ErrorCode, string[]> on
         /// i.e. if two or more references contain a declaration with the same fully qualified name. 
         /// Throws an ArgumentNullException if the given diagnostics are null. 
         /// </summary>
-        internal References Remove(NonNullable<string> source, Action<ErrorCode, string[]> onError) =>
+        internal References Remove(NonNullable<string> source, Action<ErrorCode, string[]> onError = null) =>
             new References(this.Declarations.Remove(source), onError);
 
         /// <summary>
@@ -116,7 +116,7 @@ internal References Remove(NonNullable<string> source, Action<ErrorCode, string[
         /// i.e. if two or more references contain a declaration with the same fully qualified name. 
         /// Throws an ArgumentNullException if the given dictionary of references is null. 
         /// </summary>
-        public References(ImmutableDictionary<NonNullable<string>, Headers> refs, Action<ErrorCode, string[]> onError)
+        public References(ImmutableDictionary<NonNullable<string>, Headers> refs, Action<ErrorCode, string[]> onError = null)
         {
             this.Declarations = refs ?? throw new ArgumentNullException(nameof(refs));
             if (onError == null) return;
@@ -199,6 +199,7 @@ internal void UpdateReferences(References externals)
         /// </summary>
         internal void RegisterDependentLock(ReaderWriterLockSlim depLock)
         {
+            #if DEBUG
             if (depLock == null) throw new ArgumentNullException(nameof(depLock));
             this.SyncRoot.EnterWriteLock();
             try
@@ -207,6 +208,7 @@ internal void RegisterDependentLock(ReaderWriterLockSlim depLock)
                 { this.DependentLocks.Add(depLock); }
             }
             finally { this.SyncRoot.ExitWriteLock(); }
+            #endif
         }
 
         /// <summary>
@@ -216,6 +218,7 @@ internal void RegisterDependentLock(ReaderWriterLockSlim depLock)
         /// </summary>
         internal void UnregisterDependentLock(ReaderWriterLockSlim depLock)
         {
+            #if DEBUG
             if (depLock == null) throw new ArgumentNullException(nameof(depLock));
             this.SyncRoot.EnterWriteLock();
             try
@@ -224,6 +227,7 @@ internal void UnregisterDependentLock(ReaderWriterLockSlim depLock)
                 { this.DependentLocks.Remove(depLock); }
             }
             finally { this.SyncRoot.ExitWriteLock(); }
+            #endif
         }
 
 

src/QsCompiler/CompilationManager/CompilationUnitManager.cs

@@ -102,7 +102,7 @@ public T FlushAndExecute<T>(Func<T> execute = null) where T : class
                     file.Flush();
                     this.PublishDiagnostics(file.Diagnostics());
                 }
-                var task =  this.EnableVerification ? this.SpawnGlobalTypeCheckingAsync(runSynchronously: true) : Task.CompletedTask;
+                var task = this.EnableVerification ? this.SpawnGlobalTypeCheckingAsync(runSynchronously: true) : Task.CompletedTask;
                 QsCompilerError.Verify(task.IsCompleted, "global type checking hasn't completed"); 
                 return execute?.Invoke();
             }
@@ -223,17 +223,18 @@ public static ImmutableHashSet<FileContentManager> InitializeFileManagers(IDicti
         /// <summary>
         /// Adds the given source file to this compilation unit, adapting the diagnostics for all remaining files as needed.
         /// If a file with that Uri is already listed as source file,
-        /// replaces the current FileContentManager for that file with a new one and initialized its content to the given one. 
+        /// replaces the current FileContentManager for that file with the given one.
+        /// If the content to update is specified and not null, replaces the tracked content in the file manager with the given one. 
         /// Throws an ArgumentNullException if any of the compulsory arguments is null or the set uri is.
         /// Throws an ArgumentException if the uri of the given text document identifier is null or not an absolute file uri. 
         /// </summary>
         public Task AddOrUpdateSourceFileAsync(FileContentManager file, string updatedContent = null)
         {
             if (file == null) throw new ArgumentNullException(nameof(file));
-            this.CompilationUnit.RegisterDependentLock(file.SyncRoot);
-            this.SubscribeToFileManagerEvents(file);
             return this.Processing.QueueForExecutionAsync(() =>
             {
+                this.CompilationUnit.RegisterDependentLock(file.SyncRoot);
+                this.SubscribeToFileManagerEvents(file);
                 this.FileContentManagers.AddOrUpdate(file.FileName, file, (k, v) => file);
                 if (updatedContent != null) file.ReplaceFileContent(updatedContent);
                 this.ChangedFiles.Add(file.FileName);
@@ -434,7 +435,7 @@ private Task SpawnGlobalTypeCheckingAsync(bool runSynchronously = false)
             var cancellationToken = runSynchronously ? new CancellationToken() : this.WaitForTypeCheck.Token;
 
             // work with a separate compilation unit instance such that processing of all further edits can go on in parallel
-            var sourceFiles = this.FileContentManagers.Values;
+            var sourceFiles = this.FileContentManagers.Values.OrderBy(m => m.FileName);
             this.ChangedFiles.RemoveAll(f => sourceFiles.Any(m => m.FileName.Value == f.Value));
             var compilation = new CompilationUnit(this.CompilationUnit.Externals, sourceFiles.Select(file => file.SyncRoot));
             var content = compilation.UpdateGlobalSymbolsFor(sourceFiles);

src/QsCompiler/Core/Core.fsproj

@@ -21,7 +21,7 @@
     <Compile Include="ExpressionTransformation.fs" />
     <Compile Include="StatementTransformation.fs" />
     <Compile Include="TreeTransformation.fs" />
-    <Compile Include="CoreDependencies.fs" />
+    <Compile Include="Dependencies.fs" />
     <Compile Include="SyntaxGenerator.fs" />
     <Compile Include="DeclarationHeaders.fs" />
     <Compile Include="SymbolResolution.fs" />

src/QsCompiler/Core/CoreDependencies.fs → src/QsCompiler/Core/Dependencies.fs

@@ -5,6 +5,7 @@ namespace Microsoft.Quantum.QsCompiler
 
 open System.Collections.Immutable
 open Microsoft.Quantum.QsCompiler.DataTypes
+open Microsoft.Quantum.QsCompiler.SyntaxTree
 
 
 type BuiltIn = {
@@ -20,19 +21,27 @@ type BuiltIn = {
     static member IntrinsicNamespace = NonNullable<string>.New "Microsoft.Quantum.Intrinsic"
     static member StandardArrayNamespace = NonNullable<string>.New "Microsoft.Quantum.Arrays"
 
+    /// returns the set of namespaces that is automatically opened for each compilation
     static member NamespacesToAutoOpen = ImmutableHashSet.Create (BuiltIn.CoreNamespace)
 
+    /// returns true if the given attributes is an entry point attributes
+    static member internal IsEntryPointAttribute (att : QsDeclarationAttribute) = att.TypeId |> function 
+        | Value tId -> tId.Namespace.Value = BuiltIn.EntryPoint.Namespace.Value && tId.Name.Value = BuiltIn.EntryPoint.Name.Value
+        | Null -> false
+
+
+    // hard dependencies in Microsoft.Quantum.Core
 
     static member Length = {
         Name = "Length" |> NonNullable<string>.New
         Namespace = BuiltIn.CoreNamespace
         TypeParameters = ImmutableArray.Create("T" |> NonNullable<string>.New)
     }
 
-    static member IndexRange = {
-        Name = "IndexRange" |> NonNullable<string>.New
-        Namespace = BuiltIn.StandardArrayNamespace
-        TypeParameters = ImmutableArray.Empty
+    static member RangeReverse = {
+        Name = "RangeReverse" |> NonNullable<string>.New
+        Namespace = BuiltIn.CoreNamespace
+        TypeParameters = ImmutableArray.Empty    
     }
 
     static member Attribute = {
@@ -41,3 +50,17 @@ type BuiltIn = {
         TypeParameters = ImmutableArray.Empty
     }
 
+    static member EntryPoint = {
+        Name = "EntryPoint" |> NonNullable<string>.New
+        Namespace = BuiltIn.CoreNamespace
+        TypeParameters = ImmutableArray.Empty
+    }
+
+
+    // "weak dependencies" in other namespaces (e.g. things used for code actions)
+
+    static member IndexRange = {
+        Name = "IndexRange" |> NonNullable<string>.New
+        Namespace = BuiltIn.StandardArrayNamespace
+        TypeParameters = ImmutableArray.Empty
+    }